Skip to content

Clarify rollForward: disable guidance for lock-file workflows in global.json docs - #53348

Merged
gewarren merged 7 commits into
mainfrom
copilot/fix-lock-file-recommendation-typo
Apr 30, 2026
Merged

Clarify rollForward: disable guidance for lock-file workflows in global.json docs#53348
gewarren merged 7 commits into
mainfrom
copilot/fix-lock-file-recommendation-typo

Conversation

Copilot AI commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

The global.json article didn’t surface an important recommendation: when you use dependency lock files, you should also pin SDK selection with rollForward: disable to keep toolchain resolution deterministic. This update adds that guidance directly where rollForward values are defined.

  • Docs update (rollForward policy table)

    • Updated the disable row in docs/core/tools/global-json.md to explicitly recommend disable for lock-file scenarios.
    • Kept the change scoped to the existing behavior table to improve discoverability at decision time.
  • Resulting guidance

    {
      "sdk": {
        "version": "8.0.302",
        "rollForward": "disable"
      }
    }

    disable now explicitly communicates: exact SDK match, and recommended use with lock files so SDK version and dependency graph remain in lockstep.


Internal previews

📄 File 🔗 Preview link
docs/core/tools/global-json.md global.json overview

Copilot AI changed the title [WIP] Fix typo in recommendation for lock files usage Clarify rollForward: disable guidance for lock-file workflows in global.json docs Apr 22, 2026
Comment thread docs/core/tools/global-json.md Outdated
Copilot AI requested a review from gewarren April 22, 2026 17:45
Clarify the behavior of the 'disable' option in global.json.
@gewarren
gewarren marked this pull request as ready for review April 22, 2026 21:08
@gewarren
gewarren requested a review from meaghanlewis as a code owner April 22, 2026 21:08
Copilot AI review requested due to automatic review settings April 22, 2026 21:08
@gewarren
gewarren requested a review from a team as a code owner April 22, 2026 21:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the global.json documentation to make SDK selection more deterministic when using lock-file-based dependency workflows, by recommending rollForward: disable directly in the rollForward behavior table.

Changes:

  • Refines the disable roll-forward policy description to emphasize exact SDK matching.
  • Adds a footnote recommending rollForward: disable when using lock files, with references to related GitHub issues.

Comment thread docs/core/tools/global-json.md Outdated
Comment thread docs/core/tools/global-json.md Outdated
Co-authored-by: Frulfump <Frulfump@users.noreply.github.com>
Comment thread docs/core/tools/global-json.md Outdated
@gewarren
gewarren requested review from a team and adegeo April 28, 2026 17:57
@gewarren
gewarren merged commit 74e8a04 into main Apr 30, 2026
11 checks passed
@gewarren
gewarren deleted the copilot/fix-lock-file-recommendation-typo branch April 30, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rollForward = disable should mention that's recommended when using lock files

5 participants