Skip to content

Remove outdated labels from breaking change issue template - #54637

Merged
gewarren merged 1 commit into
mainfrom
svick-patch-1
Jul 7, 2026
Merged

Remove outdated labels from breaking change issue template#54637
gewarren merged 1 commit into
mainfrom
svick-patch-1

Conversation

@svick

@svick svick commented Jul 3, 2026

Copy link
Copy Markdown
Member

Removed 'Pri1' and 'doc-idea' labels from breaking change issue template. These labels don't seem to exist anymore.

(Note that this doesn't seem to be a problem when the issue template is used directly on GitHub, but it confused copilot.)


Internal previews

📄 File 🔗 Preview link
.github/ISSUE_TEMPLATE/02-breaking-change.yml .github/ISSUE_TEMPLATE/02-breaking-change

Removed 'Pri1' and 'doc-idea' labels from breaking change issue template. These labels don't seem to exist anymore.
Copilot AI review requested due to automatic review settings July 3, 2026 15:04
@svick
svick requested a review from a team as a code owner July 3, 2026 15:04
@dotnetrepoman dotnetrepoman Bot added this to the July 2026 milestone Jul 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub “.NET breaking change” issue template to stop auto-applying labels that appear to be deprecated, keeping issue triage metadata aligned with the current label set.

Changes:

  • Removed the Pri1 label from the breaking change issue template.
  • Removed the doc-idea label from the breaking change issue template.

@gewarren gewarren left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svick

@gewarren
gewarren merged commit 1e578c1 into main Jul 7, 2026
14 checks passed
@gewarren
gewarren deleted the svick-patch-1 branch July 7, 2026 00:11
svick added a commit to dotnet/runtime that referenced this pull request Jul 16, 2026
Addresses the problems described in
#130184 in the
`breaking-change-doc` skill.

## Version detection (`Get-VersionInfo.ps1`)

Replaces the unreliable `last tag + 1` heuristic with
release-branch–based detection:

- Determines the version from the existence of
`release/<major>.<minor>-preview<N>` (and `-rc<N>` / GA) branches, with
cadence-aware rollover (**7 previews, then 2 RCs, then GA**), so a
change on `main` correctly rolls Preview 7 → RC 1 and RC 2 → GA.
- Uses own-commit containment (compare API) and, for already-shipped
past majors whose preview/RC branches were pruned, scans the persistent
release **tags** to recover the exact first preview/RC.
- Detects **potential** backports via the primary PR's cross-reference
graph (robust to head-branch names and deleted branches) and reports an
earlier milestone as **tentative** — with a `FallbackVersion` — when an
unverified linked release-branch PR is found.

This fixes the observed case where a `main` change was mislabeled
Preview 6 instead of Preview 7.

## Issue creation link (`Build-IssueComment.ps1`)

- **Hybrid pre-filled link**: keeps the issue body in the URL only when
the whole URL fits within a conservative ~8000-byte budget (verified:
GitHub returns 414 above ~8192 bytes); otherwise it opens a blank editor
with title/labels/assignee pre-filled and embeds the body in a
copy-paste code block. This fixes the **414 Request URL too long**
error.
- Sources `labels` and `assignees` from the dotnet/docs issue template
instead of hardcoding `Pri1`/`doc-idea` (which don't exist — see
dotnet/docs#54637).
- Replaces the redaction-prone `mailto:` link with a plain-text
notification-alias reminder, fixing the broken email formatting.

## Skill doc (`SKILL.md`)

Updated to match the above, plus removed duplicated/stale content.

## Not addressed here

The `400 bad request: Authorization header is badly formatted`
security-scan failure is a PAT-pool secret configuration issue, not a
skill-script problem, so it's out of scope for this PR.

/cc @ericstj @jeffhandley

> [!NOTE]
> This PR description and the code changes were generated with AI
assistance from Copilot (GitHub Copilot CLI).

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants