-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Fixed references to RC2, OS X, and Update 2 #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ The scripts in this document describe the steps necessary to build a number of t | |
| Prerequisites | ||
| ------------- | ||
|
|
||
| These scripts assume that .NET Core RC2 CLI SDK preview and VS Code or another code editor are installed on the machine. | ||
| These scripts assume that .NET Core 1.0 and VS Code or another code editor are installed on the machine. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this change is not correct since this is talking about the SDK. @blackdwarf what will be the official name of the SDK at RTM?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Undid change for now. |
||
|
|
||
| A solution using only .NET Core projects | ||
| ---------------------------------------- | ||
|
|
@@ -36,7 +36,7 @@ A solution using only .NET Core projects | |
|
|
||
| 1. Open a command-line on `GoldenCLI/src/Library`, then do `dotnet new`. | ||
| 2. Edit `GoldenCLI/src/Library/project.json` and remove the `buildOptions` section. | ||
| 3. Change dependencies to `"NETStandard.Library": "1.5.0-rc2-24027", "Newtonsoft.Json": "9.0.1-beta1"`. | ||
| 3. Change dependencies to `"NETStandard.Library": "1.6.0", "Newtonsoft.Json": "9.0.1-beta1"`. | ||
| 4. Under `frameworks`, change `netcoreapp1.0` to `netstandard1.5`. | ||
| 5. From `GoldenCLI/src/Library`, run `dotnet restore`. | ||
| 6. Rename `Program.cs` to `Thing.cs`, and replace its contents with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ The scripts in this document describe the steps necessary to build a number of t | |
| Prerequisites | ||
| ------------- | ||
|
|
||
| These scripts assume that .NET Core RC2 CLI SDK preview and VS Code or another code editor are installed on the machine. | ||
| These scripts assume that .NET Core 1.0 and VS Code or another code editor are installed on the machine. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as previous comment about the SDK
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed |
||
|
|
||
| A solution using only .NET Core projects | ||
| ---------------------------------------- | ||
|
|
@@ -111,4 +111,4 @@ You should now be able to `dotnet run` and get "Hello World!" and "42" output to | |
|
|
||
| You should now be able to run the test and verify it passes by doing `dotnet test`. | ||
|
|
||
| **Note**: This will temporarily fail on OS X. This is a known issue. | ||
| **Note**: This will temporarily fail on macOS. This is a known issue. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one shouldn't be changed. The name of that version is still OS X for older versions. It's only when we're talking about OS X in a generic way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this file was deleted in a subsequent PR