Port System.Text.Json source comments to Docs - #2360
Closed
carlossanlop wants to merge 8 commits into
Closed
Conversation
Contributor
Author
|
@mairaw @rpetrusha please take a look whenever possible. |
ahsonkhan
reviewed
Apr 25, 2019
ahsonkhan
approved these changes
Apr 25, 2019
ahsonkhan
left a comment
ahsonkhan
left a comment
Contributor
There was a problem hiding this comment.
Some nits, but looks good to me.
Removing extra spaces, thanks ahsonkhan. Co-Authored-By: carlossanlop <1175054+carlossanlop@users.noreply.github.com>
bartonjs
reviewed
Apr 25, 2019
ahsonkhan
reviewed
Apr 25, 2019
bartonjs
reviewed
Apr 25, 2019
Fixed one ".On" and two ".If" glued sentences.
bartonjs
approved these changes
Apr 25, 2019
ahsonkhan
reviewed
Apr 25, 2019
ahsonkhan
reviewed
Apr 25, 2019
mairaw
added
new-content
Removed remark that is not ready to be published.
Contributor
Author
|
@ahsonkhan Do you have any additional comments about the descriptions? |
Contributor
Author
|
Since there are no more comments from @ahsonkhan, can we get this merged, @rpetrusha @mairaw? |
rpetrusha
suggested changes
May 6, 2019
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
I've left a number of suggestions and comments for you to address, @carlossanlop.
rpetrusha suggestions Co-Authored-By: carlossanlop <1175054+carlossanlop@users.noreply.github.com>
carlossanlop
commented
May 7, 2019
carlossanlop
commented
May 7, 2019
carlossanlop
commented
May 7, 2019
carlossanlop
commented
May 7, 2019
carlossanlop
commented
May 7, 2019
carlossanlop
commented
May 7, 2019
carlossanlop
commented
May 7, 2019
Suggestions by rpetrusha Co-Authored-By: carlossanlop <1175054+carlossanlop@users.noreply.github.com>
Contributor
Author
|
As discussed offline with @rpetrusha, I will close this PR and send a new one because of the unmergeable conflicts generated in the latest CI update: #2405, which heavily changed some APIs after I submitted this review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automatically ported triple slash source code comments found in System.Text.Json that did not exist in dotnet-api-docs.
Fixes #Issue_Number (if available)