Add missing platforms extensions for preview 7 - #4591
Merged
Conversation
Collaborator
Author
|
The diff looks good to me. The property that was missing that alerted us to the missing assemblies is now present at https://review.docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.logging.console.consoleloggeroptions.useutctimestamp?view=dotnet-plat-ext-5.0&branch=pr-en-us-4591. |
Collaborator
Author
|
@carlossanlop After we merge this, is there an easy way to find/bring in any missing doc comments? |
gewarren
commented
Jul 30, 2020
gewarren
left a comment
gewarren
left a comment
Collaborator
Author
There was a problem hiding this comment.
Marked all new members.
| </remarks> | ||
| </Docs> | ||
| </Member> | ||
| <Member MemberName="RedactLoggedHeaders"> |
| </remarks> | ||
| </Docs> | ||
| </Member> | ||
| <Member MemberName="AddHttpClient<TClient,TImplementation>"> |
| </remarks> | ||
| </Docs> | ||
| </Member> | ||
| <Member MemberName="AddHttpClient<TClient,TImplementation>"> |
| <remarks>To be added.</remarks> | ||
| </Docs> | ||
| </Member> | ||
| <Member MemberName=".ctor"> |
| <remarks>To be added.</remarks> | ||
| </Docs> | ||
| </Member> | ||
| <Member MemberName=".ctor"> |
| <remarks>To be added.</remarks> | ||
| </Docs> | ||
| </Member> | ||
| <Member MemberName="ShouldRedactHeaderValue"> |
| <remarks>To be added.</remarks> | ||
| </Docs> | ||
| </Member> | ||
| <Member MemberName="UseUtcTimestamp"> |
| <remarks>To be added.</remarks> | ||
| </Docs> | ||
| </Member> | ||
| <Member MemberName="CreateInstance"> |
BillWagner
approved these changes
Jul 31, 2020
BillWagner
left a comment
BillWagner
left a comment
Member
There was a problem hiding this comment.
This LGTM @gewarren
Go ahead and 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See dotnet/docs#19739 (comment).