Skip to content

Fix Socket.Close timeout parameter doc - #7888

Merged
gewarren merged 1 commit into
dotnet:mainfrom
deeprobin:rt-issue-14336
Apr 1, 2022
Merged

Fix Socket.Close timeout parameter doc#7888
gewarren merged 1 commit into
dotnet:mainfrom
deeprobin:rt-issue-14336

Conversation

@deeprobin

Copy link
Copy Markdown
Contributor

Summary

As described in dotnet/runtime#64860 (comment), this PR provides a fix for seconds -> milliseconds, since setsockopt expects a milliseconds value.

/cc @danmoseley
/cc @stephentoub

@deeprobin
deeprobin requested a review from a team as a code owner March 28, 2022 20:20
@ghost

ghost commented Mar 28, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

As described in dotnet/runtime#64860 (comment), this PR provides a fix for seconds -> milliseconds, since setsockopt expects a milliseconds value.

/cc @danmoseley
/cc @stephentoub

Author: deeprobin
Assignees: -
Labels:

area-System.Net.Sockets

Milestone: -

@danmoseley danmoseley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Please ensure that the XML comments in the code also say milliseconds.

@deeprobin

Copy link
Copy Markdown
Contributor Author

thanks. Please ensure that the XML comments in the code also say milliseconds.

In the current code this is undocumented.

@opbld30

opbld30 commented Mar 28, 2022

Copy link
Copy Markdown

Docs Build status updates of commit 4ec523c:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/Socket.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren
gewarren merged commit 507984c into dotnet:main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants