Skip to content

Fixes required for stable preview builds + some improvements - #575

Merged
mmitche merged 52 commits into
dotnet:mainfrom
mmitche:attempt-stabilize-package-version
Jun 26, 2025
Merged

Fixes required for stable preview builds + some improvements#575
mmitche merged 52 commits into
dotnet:mainfrom
mmitche:attempt-stabilize-package-version

Conversation

@mmitche

@mmitche mmitche commented May 15, 2025

Copy link
Copy Markdown
Member

Sets of fixes required for creating stable preview builds.

  • Use the ref pack versions in place of the x64 runtime version
  • Use the platform version for places that should use non-stable versions
  • Fix some places that were using the wrong version type
  • Remove all places that were using arch specific versions
  • Remove all the special property setups for the arch specific versions.

@mmitche
mmitche requested review from a team as code owners May 15, 2025 21:58
@mmitche
mmitche force-pushed the attempt-stabilize-package-version branch from c4026b6 to 5f3e50d Compare May 15, 2025 22:11
Comment thread src/diagnostics/eng/Versions.props
@jkoritzinsky

Copy link
Copy Markdown
Member

Do you have a validation run of the full unified build pipeline (with later build passes)?

@jkoritzinsky

Copy link
Copy Markdown
Member

Also, I think it would be useful to have a parameter to the official pipeline to select building with stabilized versions so we can easily validate (in the same way we can turn signing and ibc on and off).

@mmitche

mmitche commented May 15, 2025

Copy link
Copy Markdown
Member Author

Also, I think it would be useful to have a parameter to the official pipeline to select building with stabilized versions so we can easily validate (in the same way we can turn signing and ibc on and off).

I think the way we'll probably ship is with the "stable" switch checked in. But a parameter that sets the value if not specific seems like a good idea.

Do you have a validation run of the full unified build pipeline (with later build passes)?

Good point. I'll get this done after I resolve the SB issue.

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions.props changes don't sync back so blocking this until the individual repos changes flowed in.

@mmitche

mmitche commented May 16, 2025

Copy link
Copy Markdown
Member Author

Versions.props changes don't sync back so blocking this until the individual repos changes flowed in.

Fine by me. I'll iterate on the stable switch and source build errors.

@ViktorHofer

Copy link
Copy Markdown
Member

Looks like the windowsdesktop, winforms and wpf ones are already in. Do you plan to submit a PR to dotnet/sdk for the sdk ones?

@mmitche

mmitche commented May 16, 2025

Copy link
Copy Markdown
Member Author

SDK: dotnet/sdk#49017

@mmitche

mmitche commented May 16, 2025

Copy link
Copy Markdown
Member Author

Diagnostics: dotnet/diagnostics#5486

@mmitche
mmitche changed the base branch from main to release/10.0.1xx-preview5 May 21, 2025 19:27
@mmitche
mmitche changed the base branch from release/10.0.1xx-preview5 to main May 21, 2025 23:55
@mmitche
mmitche changed the base branch from main to release/10.0.1xx-preview5 May 21, 2025 23:56
@mmitche

mmitche commented May 23, 2025

Copy link
Copy Markdown
Member Author

@mmitche

mmitche commented May 27, 2025

Copy link
Copy Markdown
Member Author

@mmitche

mmitche commented May 27, 2025

Copy link
Copy Markdown
Member Author

@mmitche
mmitche changed the base branch from release/10.0.1xx-preview5 to main May 30, 2025 17:43
@mmitche
mmitche requested a review from premun as a code owner May 30, 2025 17:43
@mmitche
mmitche force-pushed the attempt-stabilize-package-version branch from 513fe33 to d2e21a4 Compare May 30, 2025 17:43
@mmitche

mmitche commented May 30, 2025

Copy link
Copy Markdown
Member Author

Rebased this back onto main

Comment thread build.sh

@jkoritzinsky jkoritzinsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime changes LGTM

@mmitche

mmitche commented Jun 18, 2025

Copy link
Copy Markdown
Member Author

dotnet/sdk#49463

@mmitche

mmitche commented Jun 20, 2025

Copy link
Copy Markdown
Member Author

Waiting on any last feedback here: dotnet/fsharp#18701

@mmitche

mmitche commented Jun 24, 2025

Copy link
Copy Markdown
Member Author

FSharp is in. Now to get that forward flow and then merge in here. Then this PR should be good to go.

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does command-line-api.proj need AllowDotNetFinalVersionKindOverride as well?

Comment thread repo-projects/windowsdesktop.proj
@mmitche
mmitche merged commit 032c08c into dotnet:main Jun 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants