Remove mono.workloads subset and VS workloads build logic from src/runtime - #6358
Merged
Merged
Conversation
The VS workloads build logic (mono.workloads subset) in src/runtime has been unused since the equivalent logic moved to src/sdk. This removes: - The mono.workloads subset and ItemGroup from eng/Subsets.props - The WorkloadsProjectRoot property from Directory.Build.props - The src/workloads/ directory (workloads.csproj, VSSetup.props/targets, mono_wasm_mobile.vsmanproj, readme.md) - The Microsoft.DotNet.Build.Tasks.Workloads dependency from Version.Details.xml and Version.Details.props - The SwixPackageVersion entry from Versions.props - The src/workloads/* exclusion from evaluate-default-paths.yml - The DarcDependenciesChanged.Microsoft_DotNet_Build_Tasks_Workloads check from xplat-setup.yml Agent-Logs-Url: https://github.com/dotnet/dotnet/sessions/93f24aa7-49fc-4f17-b9e6-15f9f2ebff2c Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jkoritzinsky
April 28, 2026 20:32
View session
jkoritzinsky
marked this pull request as ready for review
April 28, 2026 20:32
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the legacy mono.workloads subset and the src/runtime/src/workloads build logic for VS workload installers/insertion metadata, since equivalent functionality now lives in src/sdk and the runtime copy is no longer used.
Changes:
- Deleted the
src/runtime/src/workloads/project and associated VS setup assets. - Removed the
Mono.Workloadssubset and its project-to-build wiring fromeng/Subsets.props. - Cleaned up runtime eng/pipeline dependencies and version properties that were only used by the removed workloads project.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/runtime/src/workloads/workloads.csproj | Removes the workloads MSBuild project that produced VS workload installers/metadata. |
| src/runtime/src/workloads/readme.md | Removes local build instructions tied to the deleted workloads project. |
| src/runtime/src/workloads/mono_wasm_mobile.vsmanproj | Removes VS manifest project used by the deleted workloads build. |
| src/runtime/src/workloads/VSSetup.targets | Removes VS drop publishing targets only used by the deleted workloads flow. |
| src/runtime/src/workloads/VSSetup.props | Removes VS drop configuration properties only used by the deleted workloads flow. |
| src/runtime/eng/pipelines/common/xplat-setup.yml | Drops a workloads-specific Darc dependency change condition. |
| src/runtime/eng/pipelines/common/evaluate-default-paths.yml | Removes src/workloads/* from always-excluded paths since the directory is removed. |
| src/runtime/eng/Versions.props | Removes SwixPackageVersion property previously only consumed by workloads.csproj. |
| src/runtime/eng/Version.Details.xml | Removes Microsoft.DotNet.Build.Tasks.Workloads dependency entry no longer needed. |
| src/runtime/eng/Version.Details.props | Removes MicrosoftDotNetBuildTasksWorkloads* version properties no longer needed. |
| src/runtime/eng/Subsets.props | Removes Mono.Workloads subset and its build item group; removes it from subset expansion. |
| src/runtime/Directory.Build.props | Removes WorkloadsProjectRoot property used only by the removed subset/project. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sbomer
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mono.workloadssubset insrc/runtime— responsible for building VS workload installers and insertion metadata for Blazor workloads — has been superseded by equivalent logic insrc/sdkand is no longer used.Removed
src/workloads/— entire directory (workloads.csproj,VSSetup.props/targets,mono_wasm_mobile.vsmanproj)eng/Subsets.props—Mono.Workloadssubset name declaration,+mono.workloadsfromAllSubsetsExpansion, and theItemGroupthat referencedworkloads.csprojDirectory.Build.props—WorkloadsProjectRootpropertyeng/Version.Details.xml/Version.Details.props—Microsoft.DotNet.Build.Tasks.Workloadsdependency and its version propertieseng/Versions.props—SwixPackageVersion(MicroBuild.Plugins.SwixBuild.Dotnet), which was exclusively consumed byworkloads.csprojeng/pipelines/common/evaluate-default-paths.yml—src/workloads/*always-exclude entryeng/pipelines/common/xplat-setup.yml—DarcDependenciesChanged.Microsoft_DotNet_Build_Tasks_Workloadscondition from the wasm dependency change check