Use default ProviderKey for Desktop bundle - #7334
Merged
Merged
Conversation
joeloff
added
Servicing-consider
Member
Author
|
Approved by tactics over email. |
lewing
approved these changes
Jun 23, 2026
joeloff
pushed a commit
to joeloff/dotnet
that referenced
this pull request
Jul 27, 2026
#### AI description (iteration 1) #### PR Classification Integration merge from public release/10.0.1xx branch to internal branch, updating dependency versions and refactoring baseline PR creation tool. #### PR Summary This PR merges the public release/10.0.1xx branch into the internal branch, primarily updating package dependency versions across the SDK and refactoring the baseline PR creation tool to use DarcLib instead of Octokit. - `eng/Version.Details.xml`: Updated all dependency versions (Microsoft.Build, Microsoft.CodeAnalysis, NuGet.*, Microsoft.AspNetCore.*, etc.) from build SHA `fe7283f2bc56523c765bc050be87a97543db180a` to `47c73391bfb8274e379c74c19694ccabff33bc3e` - `eng/tools/CreateBaselineUpdatePR/PRCreator.cs`: Replaced Octokit-based GitHub API client with DarcLib's IRemoteGitRepo abstraction for cross-provider (GitHub/AzDO) support, changed tree/commit operations to use GitFile-based changesets, and introduced deterministic head branch naming <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: dotnet#7237, dotnet#7238, dotnet#7239, dotnet#7240, dotnet#7244, dotnet#7254, dotnet#7267, dotnet#7268, dotnet#7269, dotnet#7275, dotnet#7304, dotnet#7321, dotnet#7325, dotnet#7332, dotnet#7334, dotnet#7346, dotnet#7358
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The Desktop Runtime bundle generates an explicit provider key instead of using the default which matches the bundle registration code. This can result in blocking the removal of a previous install. As shown below, the provider key and dependent (bundle registration code) are not the same.
Customer Impact
When the deferred removal key is set to
nextSession, the old version of the runtime is not removed because there are multiple dependents. The screenshot below shows that the 10.0.2 and 10.0.9 installs are registered against the same provider.This also results in overwriting the provider data when attempting to perform an out-of-order installs. This scenario is supported to allow ISVs to redist runtimes with their software. If a user already has a newer runtime installed, we do not want the ISV install to fail.
Regression
Yes, this is a regression from .NET 9.0
Testing
Manually verified. Below is a screenshot from a dev build showing that the provider key and dependent now match