Skip to content

[main] Update dependencies from dotnet/runtime - #28164

Merged
dotnet-maestro[bot] merged 4 commits into
mainfrom
darc-main-2396c4c1-15ed-4246-961f-3900fa5b2104
Jun 8, 2022
Merged

[main] Update dependencies from dotnet/runtime#28164
dotnet-maestro[bot] merged 4 commits into
mainfrom
darc-main-2396c4c1-15ed-4246-961f-3900fa5b2104

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jun 6, 2022

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: daf314a8-d8c8-4b54-8dcc-08d82e674dfc
  • Build: 20220607.1
  • Date Produced: June 7, 2022 1:47:01 PM UTC
  • Commit: 0712aebead42b6605fda32687b341de08f530a3c
  • Branch: refs/heads/main

…0605.4

Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Logging
 From Version 7.0.0-preview.6.22279.1 -> To Version 7.0.0-preview.6.22305.4

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@dougbu

dougbu commented Jun 6, 2022

Copy link
Copy Markdown
Contributor

Just leave this alone. dotnet/runtime team e.g. @eerhardt and @davidfowl are working on a fix in that repo. See also dotnet/aspnetcore#41999

@HaoK

HaoK commented Jun 7, 2022

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@dougbu

dougbu commented Jun 7, 2022

Copy link
Copy Markdown
Contributor

Something is weird here. I triggered the subscription for 'main' this morning but the PR didn't update. Trying again…

…0607.1

Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Logging
 From Version 7.0.0-preview.6.22279.1 -> To Version 7.0.0-preview.6.22307.1
@dougbu

dougbu commented Jun 7, 2022

Copy link
Copy Markdown
Contributor

That's better 😄

Comment thread test/EFCore.Design.Tests/DesignApiConsistencyTest.cs Outdated

@dougbu dougbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes only to ensure the bot doesn't merge this on us while discussing @eerhardt's question

These tests are now sealed, so they no longer need to be skipped.
@eerhardt
eerhardt requested a review from dougbu June 8, 2022 17:04

@dougbu dougbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it builds, looks much cleaner 😃 A little less @davidfowl code however 😢

@dougbu

dougbu commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Thanks for making the changes @eerhardt. I was about to give it a shot, but you got to it first🥇

@dotnet-maestro
dotnet-maestro Bot merged commit b19c1e7 into main Jun 8, 2022
@dotnet-maestro
dotnet-maestro Bot deleted the darc-main-2396c4c1-15ed-4246-961f-3900fa5b2104 branch June 8, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants