Skip to content

[Component governance] Update Azure.Identity dependency#32108

Closed
javiercn wants to merge 2 commits into
mainfrom
javiercn/update-azure-identity-dependency
Closed

[Component governance] Update Azure.Identity dependency#32108
javiercn wants to merge 2 commits into
mainfrom
javiercn/update-azure-identity-dependency

Conversation

@javiercn

Copy link
Copy Markdown
Member

Updates the Azure.Identity version.

@javiercn
javiercn requested a review from a team October 20, 2023 15:55
@roji

roji commented Oct 20, 2023

Copy link
Copy Markdown
Member

FYI I know SqlClient are working to update the dependency on its side, and we don't usually take direct dependencies on their transitive dependencies. But it may be justified in this case...

@ajcvickers

ajcvickers commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

@javiercn What are the circumstances here that mean we should add an explicit reference to the transient rather than updating the direct dependency? (If the direct dependency isn't updated yet, then that's something that needs to be done on SqlClient so that it can flow through to here.)

@amcasey

amcasey commented Oct 24, 2023

Copy link
Copy Markdown
Member

I'm not a nuget dependency expert, but it looks like 5.1.1 is the newest version of SqlClient and it depends on Azure.Identity 1.7.0 (or newer?).

@amcasey

amcasey commented Oct 24, 2023

Copy link
Copy Markdown
Member

But: dotnet/SqlClient#2189

@ajcvickers

Copy link
Copy Markdown
Contributor

Right. SqlClient needs to ship a new package, then we can depend on that.

@ErikEJ

ErikEJ commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

And it needs to be a LTS version I guess?

@ajcvickers

Copy link
Copy Markdown
Contributor

Fixed by #32187

@ajcvickers ajcvickers closed this Oct 30, 2023
@ErikEJ

ErikEJ commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

@ajcvickers how fixed? 5.1.2 does not include an update..

@roji roji reopened this Oct 30, 2023
@ajcvickers

Copy link
Copy Markdown
Contributor

There is nothing to track here. We will not be taking a direct dependency on Azure.Identity. This was discussed in Tactics.

@ajcvickers ajcvickers closed this Nov 13, 2023
@AndriySvyryd
AndriySvyryd deleted the javiercn/update-azure-identity-dependency branch December 6, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants