[release/9.0] Update SQLitePCLRaw package versions#38606
Conversation
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request updates EFCore’s SQLite package graph to consistently resolve to SQLitePCLRaw 3.0.3 (with SQLitePCLRaw.lib.e_sqlite3 pinned to 3.53.3), migrates SQLite test projects from bundle packages to provider packages, and removes the obsolete e_sqlite3mc test target while skipping a known-failing SQLite query test for Issue #32561.
Changes:
- Bump
SQLitePCLRawVersionto 3.0.3 and centrally pinSQLitePCLRaw.lib.e_sqlite3to 3.53.3; removebundle_sqlite3from central package wiring. - Update
Microsoft.Data.Sqlite.sqlite3.Tests/winsqlite3.Teststo referenceSQLitePCLRaw.core+ provider packages and add provider initialization shims in the test framework. - Retire
Microsoft.Data.Sqlite.e_sqlite3mc.Testsfrom project/solution wiring and skipParameter_collection_Concat_column_collectionon SQLite due to Issue #32561.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/Microsoft.Data.Sqlite.Tests/TestUtilities/SqliteTestFramework.cs | Adds provider initialization shims for SQLITE3/WINSQLITE3 test runs. |
| test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.winsqlite3.Tests.csproj | Switches from bundle_winsqlite3 to SQLitePCLRaw.core + provider.winsqlite3. |
| test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.sqlite3.Tests.csproj | Switches from bundle_sqlite3 to SQLitePCLRaw.core + provider.sqlite3. |
| test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.e_sqlite3mc.Tests.csproj | Deletes the obsolete e_sqlite3mc test project. |
| test/EFCore.Sqlite.FunctionalTests/Query/PrimitiveCollectionsQuerySqliteTest.cs | Changes a known failing test to an explicit skip for Issue #32561. |
| test/Directory.Packages.props | Replaces bundle package pins with provider package pins for tests. |
| src/Microsoft.Data.Sqlite.Core/Properties/InternalsVisibleTo.cs | Removes InternalsVisibleTo for the deleted e_sqlite3mc test assembly. |
| Microsoft.Data.Sqlite.slnf | Removes the deleted e_sqlite3mc test project from the solution filter. |
| eng/Versions.props | Updates SQLitePCLRawVersion to 3.0.3. |
| EFCore.sln | Removes the deleted e_sqlite3mc test project from the solution and build configs. |
| Directory.Packages.props | Removes bundle_sqlite3 version and pins SQLitePCLRaw.lib.e_sqlite3 to 3.53.3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
…-amd64 Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
…tion Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.sqlite3mc.Tests.csproj:16
- This test project references Microsoft.Data.Sqlite.Core (which depends on SQLitePCLRaw.core via central versioning), but also overrides SQLitePCLRaw.core to 3.0.3. NuGet will unify the dependency graph for this project to use SQLitePCLRaw.core 3.0.3 at runtime, which can introduce runtime/API incompatibilities if Microsoft.Data.Sqlite.Core was compiled against 2.1.12. If SQLite3MC.PCLRaw.bundle requires 3.x, consider updating the repo-wide SQLitePCLRaw.core version (or isolating this test project so it doesn’t combine 2.x-compiled code with 3.x runtime assemblies), and document the rationale here.
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
…er_max_subquery Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Fixes #38257
Backports #36551
Description
Update
SQLitePCLRaw.bundle_e_sqlite3to2.1.12Customer impact
Current version had high-severity CVEs.
How found
Reported by multiple customers.
Regression
No.
Testing
Existing coverage.
Risk
Low-to-moderate. This is a major version upgrade. It drops support for
uap10.0and classic Xamarin and requires newer native runtimes.