Skip to content

Dead end the Microsoft.Extensions.Configuration.NewtonsoftJson package - #3833

Merged
Anipik merged 4 commits into
dotnet:masterfrom
Anipik:deadEnd
Feb 23, 2021
Merged

Dead end the Microsoft.Extensions.Configuration.NewtonsoftJson package#3833
Anipik merged 4 commits into
dotnet:masterfrom
Anipik:deadEnd

Conversation

@Anipik

@Anipik Anipik commented Feb 21, 2021

Copy link
Copy Markdown

Fixes #3816

  • removing the Microsoft.Extensions.Configuration.NewtonsoftJson package
  • updating the preview label 3 (just for consistency, we wont be shipping any packages from here)
  • updating the readme file
  • It doesnt seem like we are using this package anywhere in our build.

@ViktorHofer

Copy link
Copy Markdown
Member

Just to make sure, did you get sign-off from the library owner's to remove it?

@Anipik

Anipik commented Feb 22, 2021

Copy link
Copy Markdown
Author

Just to make sure, did you get sign-off from the library owner's to remove it?

I think runtime team is supposed to own this package and i dont think we have any person assigned as owner for this one.

@davidfowl

Copy link
Copy Markdown
Member

Why are we doing this?

@eerhardt

Copy link
Copy Markdown
Member

@davidfowl - more reasoning than what is listed in #3816:

  1. This is the only remaining "shipping" package in dotnet/extensions. This will allow us to no longer build/maintain the dotnet/extensions repo in the main branch.
  2. We moved the rest of the packages either to dotnet/aspnetcore or dotnet/runtime. Moving this one to dotnet/runtime will make a "product dependency" from dotnet/runtime to Newtonsoft.Json, which isn't ideal. dotnet/rutnime is supposed to be the "bottom of the stack".

So unless we can find another home for this package (which only has 42k total downloads in 2 years), it doesn't warrant the maintenance burden.

Is there some unique benefit this package provides that https://www.nuget.org/packages/Microsoft.Extensions.Configuration.Json/ doesn't?

Comment thread eng/Versions.props
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<PreReleaseVersionIteration>2</PreReleaseVersionIteration>
<PreReleaseVersionIteration>3</PreReleaseVersionIteration>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this getting mvoed to 3 now (vs. when we branch?)

@Anipik Anipik Feb 22, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just combined the changes together, we wont be building or shipping anything from this.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it being retired going forward? Or will there be things for preview 3?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its being retired going forward. we dont want to ship anything in preview2 as well from extensions repo.

@davidfowl

Copy link
Copy Markdown
Member

Got it, if we don't see the value nor the usage then I'm ok with it.

@Anipik
Anipik merged commit ffb4ef4 into dotnet:master Feb 23, 2021
@Anipik
Anipik deleted the deadEnd branch February 23, 2021 01:25
@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead end the Config.NewtonsoftJson package

6 participants