Adopt Polly V8 in Microsoft.Extensions.Resilience

[martintmk]

This PR adopts the new Polly.Extensions package.

All the features introduced in Microsoft.Extensions.Resilience are now built into Polly V8. This makes most of the code in this library redundant.

The library will now only expose resilience enrichment and some extensions for ResilienceContext.

var services = new ServiceCollection();
services.AddResilienceEnrichment();

API changes:

Old API

services
    .AddResiliencePipeline<string>("my-pipeline")
    .AddRetryPolicy("my-retry", options =>
    {
        options.RetryCount = 3;
        options.BaseDelay = TimeSpan.FromSeconds(5);
    })
    .AddTimeoutPolicy("my-timeout", options =>
    {
        options.TimeoutInterval = TimeSpan.FromSeconds(30);
    });

New Polly V8 API:

new ServiceCollection()
    .AddResilienceStrategy("my-strategy", builder => builder
    .AddRetry(new RetryStrategyOptions
    {
        StrategyName = "my-retry",
        RetryCount = 3,
        BaseDelay = TimeSpan.FromSeconds(1)
    })
    .AddTimeout(new TimeoutStrategyOptions
    {
        Timeout = TimeSpan.FromSeconds(30),
        StrategyName = "my-timeout"
    }));

The PR won't be mergeable until we adopt V8 in Microsoft.Extensions.Http.Resilience

Microsoft Reviewers: Open in CodeFlow

[martintmk]

cc @martincostello

[martincostello]

😍

[martincostello]

Does context need a null check?

[martintmk]

Nope, it will never be null. Polly infra makes sure of that.

[RussKie]

Adding _ = Throw.IfNull(context); shouldn't hurt.

[geeknoid]

We generally reserve Throw.IfNull for public methods. Internally within the context of an assembly, we have the C# compiler's null rules that protect us.

[martintmk]

Yeah, the validation is arbitrary as the null won't ever come here.

[martincostello]

Suggested change

	/// This method adds additional dimensions on top of the default ones that are built-in to Polly library. These include:
	/// This method adds additional dimensions on top of the default ones that are built-in to the Polly library. These include:

[RussKie]

Suggested change

	/// <exception cref="ArgumentNullException">Thrown when <paramref name="context"/> is <see langword="null"/>.</exception>
	/// <exception cref="ArgumentNullException"><paramref name="context"/> is <see langword="null"/>.</exception>

[RussKie]

Suggested change

	/// <exception cref="ArgumentNullException">Thrown when <paramref name="services"/> or <paramref name="configure"/> is <see langword="null"/>.</exception>
	/// <exception cref="ArgumentNullException"><paramref name="services"/> or <paramref name="configure"/> is <see langword="null"/>.</exception>

[RussKie]

Adding _ = Throw.IfNull(context); shouldn't hurt.

[RussKie]

@martintmk the new packages must be available in dotnet-public. Here's the instruction to get those there.

[martintmk]

I'll leave it here in draft for a while. I need to work on alpha2 to address some issues first.

[joperezr]

@martintmk is this now superseded by #4108? If so, can we go ahead and close this one?

[martintmk]

@martintmk is this now superseded by #4108? If so, can we go ahead and close this one?

@joperezr

This PR is for Microsoft.Extensions.Resilience while the other is for Microsoft.Extensions.Http.Resilience.

I'll continue on this one once the #4108 is merged.

[martintmk]

@RussKie , @geeknoid

Now I am getting the following code-coverate error, even though I haven't touched these projects:

Any idea how to move forward? Is it ok to decrease the code-coverage threshold?

[geeknoid]

We're still fine-tuning the coverage stuff, so yes it's fine to decrease the coverage numbers.