Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove the tests for obsolete members
  • Loading branch information
jeffhandley committed Apr 16, 2025
commit 9918c1698a341a05158666603fe5695ceb751477
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ public class ChatOptionsTests
public void Constructor_Parameterless_PropsDefaulted()
{
ChatOptions options = new();
#pragma warning disable CS0618 // Type or member is obsolete
Assert.Null(options.ChatThreadId);
#pragma warning restore CS0618 // Type or member is obsolete
Assert.Null(options.ConversationId);
Assert.Null(options.Temperature);
Assert.Null(options.MaxOutputTokens);
Expand All @@ -32,9 +29,6 @@ public void Constructor_Parameterless_PropsDefaulted()
Assert.Null(options.AdditionalProperties);

ChatOptions clone = options.Clone();
#pragma warning disable CS0618 // Type or member is obsolete
Assert.Null(options.ChatThreadId);
#pragma warning restore CS0618 // Type or member is obsolete
Assert.Null(options.ConversationId);
Assert.Null(clone.Temperature);
Assert.Null(clone.MaxOutputTokens);
Expand Down Expand Up @@ -73,11 +67,6 @@ public void Properties_Roundtrip()
["key"] = "value",
};

#pragma warning disable CS0618 // Type or member is obsolete
options.ChatThreadId = "54321";
Assert.Equal("54321", options.ChatThreadId);
#pragma warning restore CS0618 // Type or member is obsolete

options.ConversationId = "12345";
options.Temperature = 0.1f;
options.MaxOutputTokens = 2;
Expand Down Expand Up @@ -165,9 +154,6 @@ public void JsonSerialization_Roundtrips()
ChatOptions? deserialized = JsonSerializer.Deserialize(json, TestJsonSerializerContext.Default.ChatOptions);
Assert.NotNull(deserialized);

#pragma warning disable CS0618 // Type or member is obsolete
Assert.Equal("12345", deserialized.ChatThreadId);
#pragma warning restore CS0618 // Type or member is obsolete
Assert.Equal("12345", deserialized.ConversationId);
Assert.Equal(0.1f, deserialized.Temperature);
Assert.Equal(2, deserialized.MaxOutputTokens);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,6 @@ public void Constructor_NullEmptyArgs_Valid()
public void Constructor_Messages_Roundtrips()
{
ChatResponse response = new();

#pragma warning disable CS0618 // Type or member is obsolete
Assert.Same(response.ChatThreadId, response.ChatThreadId);
#pragma warning restore CS0618 // Type or member is obsolete
Assert.Same(response.ConversationId, response.ConversationId);

Assert.NotNull(response.Messages);
Assert.Same(response.Messages, response.Messages);

Expand All @@ -55,16 +49,6 @@ public void Properties_Roundtrip()
{
ChatResponse response = new();

#pragma warning disable CS0618 // Type or member is obsolete
Assert.Null(response.ChatThreadId);
#pragma warning restore CS0618 // Type or member is obsolete
Assert.Null(response.ConversationId);
response.ConversationId = "12345";
Assert.Equal("12345", response.ConversationId);
#pragma warning disable CS0618 // Type or member is obsolete
Assert.Equal("12345", response.ChatThreadId);
#pragma warning restore CS0618 // Type or member is obsolete

Assert.Null(response.ResponseId);
response.ResponseId = "id";
Assert.Equal("id", response.ResponseId);
Expand Down Expand Up @@ -104,7 +88,6 @@ public void JsonSerialization_Roundtrips()
{
ResponseId = "id",
ModelId = "modelId",
ConversationId = "12345",
CreatedAt = new DateTimeOffset(2022, 1, 1, 0, 0, 0, TimeSpan.Zero),
FinishReason = ChatFinishReason.ContentFilter,
Usage = new UsageDetails(),
Expand All @@ -122,7 +105,6 @@ public void JsonSerialization_Roundtrips()

Assert.Equal("id", result.ResponseId);
Assert.Equal("modelId", result.ModelId);
Assert.Equal("12345", result.ConversationId);
Assert.Equal(new DateTimeOffset(2022, 1, 1, 0, 0, 0, TimeSpan.Zero), result.CreatedAt);
Assert.Equal(ChatFinishReason.ContentFilter, result.FinishReason);
Assert.NotNull(result.Usage);
Expand All @@ -149,7 +131,6 @@ public void ToChatResponseUpdates()
{
ResponseId = "12345",
ModelId = "someModel",
ConversationId = "someConversation",
FinishReason = ChatFinishReason.ContentFilter,
CreatedAt = new DateTimeOffset(2024, 11, 10, 9, 20, 0, TimeSpan.Zero),
AdditionalProperties = new() { ["key1"] = "value1", ["key2"] = 42 },
Expand All @@ -161,7 +142,6 @@ public void ToChatResponseUpdates()

ChatResponseUpdate update0 = updates[0];
Assert.Equal("12345", update0.ResponseId);
Assert.Equal("someConversation", update0.ConversationId);
Assert.Equal("someMessage", update0.MessageId);
Assert.Equal("someModel", update0.ModelId);
Assert.Equal(ChatFinishReason.ContentFilter, update0.FinishReason);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ public async Task ToChatResponse_SuccessfullyCreatesResponse(bool useAsync)
Assert.Equal(new DateTimeOffset(2, 2, 3, 4, 5, 6, TimeSpan.Zero), response.CreatedAt);
Assert.Equal("model123", response.ModelId);

#pragma warning disable CS0618 // Type or member is obsolete
Assert.Equal("123", response.ChatThreadId);
#pragma warning restore CS0618 // Type or member is obsolete
Assert.Equal("123", response.ConversationId);

ChatMessage message = response.Messages.Single();
Expand Down
Loading