Skip to content

Add back net9.0 version of the aieval dotnet tool #6396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shyamnamboodiripad merged 1 commit into from
May 8, 2025
Merged

Add back net9.0 version of the aieval dotnet tool #6396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add back net9.0 version of the aieval dotnet tool 
In #6148, we disabled net9.0 TFM for the aieval tool to work around the race described in dotnet/sdk#47696. The underlying issue was subsequently fixed in the SDK (via dotnet/sdk#47788). However, this fix has not been backported to the dotnet 9 SDK yet.

The SDK team is working on backporting the fix (see discussion in dotnet/sdk#47788 (comment)). But in the meanwhile, we can add back the net9.0 TFM and continue to work around the race by disabling parallel build.

This would help users of the aieval tool sidestep errors such as the ones described in #6388 when they dont have dotnet8 installed on the machine.

We can remove this workaround, once the backported fix is available in the dotnet 9 SDK.
  • Loading branch information
@shyamnamboodiripad
shyamnamboodiripad committed May 8, 2025
commit 2c7e8f92c5a0639a44a7f41a744df6a7cb98d1f8
13 changes: 10 additions & 3 deletions ...rosoft.Extensions.AI.Evaluation.Console/Microsoft.Extensions.AI.Evaluation.Console.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@
<PropertyGroup>
<Description>A command line dotnet tool for generating reports and managing evaluation data.</Description>
<OutputType>Exe</OutputType>
<!-- Building only one TFM due to bug: https://github.com/dotnet/sdk/issues/47696
Once this is fixed, we can go back to building multiple. -->
<TargetFrameworks>$(MinimumSupportedTfmForPackaging)</TargetFrameworks>
<TargetFrameworks>$(NetCoreTargetFrameworks)</TargetFrameworks>
<RootNamespace>Microsoft.Extensions.AI.Evaluation.Console</RootNamespace>
<!-- EA0000: Use source generated logging methods for improved performance. -->
<NoWarn>$(NoWarn);EA0000</NoWarn>
Expand All @@ -22,6 +20,15 @@
<MinMutationScore>0</MinMutationScore>
</PropertyGroup>

<!--
Disable parallel build to work around https://github.com/dotnet/sdk/issues/47696. The problem has been fixed in
https://github.com/dotnet/sdk/pull/47788, however the fix has not yet been back ported to the dotnet 9 SDK. We can
remove this workaround once the fix is available in the dotnet 9 SDK.
-->
<PropertyGroup>
<BuildInParallel>false</BuildInParallel>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Azure.Identity" />
<PackageReference Include="Azure.Storage.Files.DataLake" />
Expand Down
Loading