Skip to content

Fix warning breaking official build, enable warningAsError in all pipelines #6988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericstj merged 4 commits into from
Oct 30, 2025
Merged

Fix warning breaking official build, enable warningAsError in all pipelines #6988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2bee64
Workaround assembly downgrade in SemanticKernel packages
ericstj Oct 30, 2025
0efc4ce
Enable warning as error in pipelines
ericstj Oct 30, 2025
160486d
Consistently apply warnAsError in BuildAndTest.yml
ericstj Oct 30, 2025
7f1b8a6
Keep warnAsError disabled for PR validation
ericstj Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions azure-pipelines-public.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,10 @@ stages:

pool:
name: $(DncEngPublicBuildPool)
demands: ImageOverride -equals build.ubuntu.2004.amd64.open
demands: ImageOverride -equals windows.vs2022preview.amd64.open

variables:
- _buildScript: $(Build.SourcesDirectory)/build.sh --ci
- _buildScript: $(Build.SourcesDirectory)/build.cmd -ci -NativeToolsOnMachine

preSteps:
- checkout: self
Expand All @@ -257,4 +257,4 @@ stages:
repoTestResultsPath: $(Build.Arcade.TestResultsPath)
skipTests: true
skipQualityGates: true
isWindows: false
isWindows: true
2 changes: 0 additions & 2 deletions azure-pipelines-unofficial.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ extends:
repoTestResultsPath: $(Build.Arcade.TestResultsPath)
skipQualityGates: ${{ eq(variables['SkipQualityGates'], 'true') }}
isWindows: true
warnAsError: 0

# ----------------------------------------------------------------
# This job build and run tests on Ubuntu
Expand Down Expand Up @@ -163,7 +162,6 @@ extends:
repoTestResultsPath: $(Build.Arcade.TestResultsPath)
skipQualityGates: ${{ eq(variables['SkipQualityGates'], 'true') }}
isWindows: false
warnAsError: 0

# ----------------------------------------------------------------
# This stage performs quality gates enforcements
Expand Down
4 changes: 2 additions & 2 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ variables:
- ${{ if and(ne(variables['runAsPublic'], 'true'), notin(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.SourceBranch'], 'refs/heads/main')) }}:
- name: enableSourceIndex
value: true
- name: sourceIndexBuildCommand
value: $(Build.SourcesDirectory)/build.cmd -ci -NativeToolsOnMachine
- ${{ else }}:
- name: enableSourceIndex
value: false
Expand Down Expand Up @@ -206,7 +208,6 @@ extends:
repoTestResultsPath: $(Build.Arcade.TestResultsPath)
skipQualityGates: ${{ eq(variables['SkipQualityGates'], 'true') }}
isWindows: true
warnAsError: 0

# ----------------------------------------------------------------
# This job build and run tests on Ubuntu
Expand Down Expand Up @@ -237,7 +238,6 @@ extends:
repoTestResultsPath: $(Build.Arcade.TestResultsPath)
skipQualityGates: ${{ eq(variables['SkipQualityGates'], 'true') }}
isWindows: false
warnAsError: 0

# ----------------------------------------------------------------
# This stage performs quality gates enforcements
Expand Down
9 changes: 6 additions & 3 deletions eng/pipelines/templates/BuildAndTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ steps:

- script: ${{ parameters.buildScript }}
-restore
-warnAsError ${{ parameters.warnAsError }}
/bl:${{ parameters.repoLogPath }}/restore.binlog
displayName: Restore

Expand All @@ -40,6 +41,7 @@ steps:

- script: ${{ parameters.buildScript }}
-restore
-warnAsError ${{ parameters.warnAsError }}
/bl:${{ parameters.repoLogPath }}/restore2.binlog
displayName: Restore solution

Expand All @@ -61,7 +63,7 @@ steps:
- script: ${{ parameters.buildScript }}
-pack
-configuration ${{ parameters.buildConfig }}
-warnAsError 1
-warnAsError ${{ parameters.warnAsError }}
/bl:${{ parameters.repoLogPath }}/pack.binlog
/p:Restore=false /p:Build=false
$(_OfficialBuildIdArgs)
Expand All @@ -71,7 +73,7 @@ steps:
- script: ${{ parameters.buildScript }}
-integrationTest
-configuration ${{ parameters.buildConfig }}
-warnAsError 1
-warnAsError ${{ parameters.warnAsError }}
/bl:${{ parameters.repoLogPath }}/integration_tests.binlog
$(_OfficialBuildIdArgs)
displayName: Run integration tests
Expand Down Expand Up @@ -158,6 +160,7 @@ steps:
# Publishing will happen in a subsequent step
- script: ${{ parameters.buildScript }}
-projects $(Build.SourcesDirectory)/src/Packages/Microsoft.Internal.Extensions.DotNetApiDocs.Transport/Microsoft.Internal.Extensions.DotNetApiDocs.Transport.proj
-warnAsError ${{ parameters.warnAsError }}
-pack
-configuration ${{ parameters.buildConfig }}
/bl:${{ parameters.repoLogPath }}/transport.binlog
Expand All @@ -173,7 +176,7 @@ steps:
-sign $(_SignArgs)
-publish $(_PublishArgs)
-configuration ${{ parameters.buildConfig }}
-warnAsError 1
-warnAsError ${{ parameters.warnAsError }}
/bl:${{ parameters.repoLogPath }}/publish.binlog
/p:Build=false
$(_OfficialBuildIdArgs)
Expand Down
5 changes: 5 additions & 0 deletions .../Microsoft.Extensions.DataIngestion.Tests/Microsoft.Extensions.DataIngestion.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
<PackageReference Include="Microsoft.SemanticKernel.Connectors.SqliteVec" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
<!-- Workaround https://github.com/microsoft/semantic-kernel/issues/13316 -->
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" VersionOverride="$(MicrosoftBclAsyncInterfacesVersion)" />
</ItemGroup>

<ItemGroup>
<Compile Include="..\Microsoft.Extensions.AI.Abstractions.Tests\TestChatClient.cs" />
<!-- We don't run Sqlite tests on Full Framework due to some native dependency issues -->
Expand Down
Loading