Skip to content

Optimize integer for loop code gen #13573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albert-du wants to merge 19 commits into from
Closed

Optimize integer for loop code gen #13573

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8b099b6
Integer n .. step .. m for loop optimization
albert-du Jul 26, 2022
02bd0f9
run fantomas
albert-du Jul 26, 2022
129e88a
Merge branch 'main' into for-loop-optimization
albert-du Jul 27, 2022
86de1fd
add benchmark
albert-du Jul 28, 2022
96fed0e
update quotations
albert-du Jul 28, 2022
5b76d57
improve il generation
albert-du Jul 28, 2022
d771c5b
Update SurfaceArea.fs
albert-du Jul 28, 2022
8889595
baseline tests
albert-du Jul 29, 2022
65e6553
test near integer max
albert-du Aug 21, 2022
aa39f2b
fix integer overflow with constant step for loops
albert-du Aug 22, 2022
606e15d
update baselines
albert-du Aug 22, 2022
c1c6bc4
test for loops in task
albert-du Aug 22, 2022
e1dc3c7
Update TheBigFileOfDebugStepping.fsx
albert-du Aug 22, 2022
2afc973
Merge branch 'main' into for-loop-optimization
albert-du Aug 22, 2022
0b93643
new benchmarks
albert-du Aug 23, 2022
5d4441d
move optimizations out of type checking
albert-du Aug 24, 2022
90154f1
Merge branch 'main' into for-loop-optimization
albert-du Aug 24, 2022
76f22df
formatting
albert-du Aug 24, 2022
eb206ff
Merge branch 'for-loop-optimization' of https://github.com/albert-du/…
albert-du Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
formatting
  • Loading branch information
@albert-du
albert-du committed Aug 24, 2022
commit 76f22dfd93f6d1cd18a53de63bf14e6e74711c97
1 change: 0 additions & 1 deletion src/Compiler/Checking/CheckExpressions.fsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ val TcFieldInit: range -> ILFieldInit -> Const
val LightweightTcValForUsingInBuildMethodCall:
g: TcGlobals -> vref: ValRef -> vrefFlags: ValUseFlag -> vrefTypeInst: TTypes -> m: range -> Expr * TType


/// Indicates whether a syntactic type is allowed to include new type variables
/// not declared anywhere, e.g. `let f (x: 'T option) = x.Value`
type ImplicitlyBoundTyparsAllowed =
Expand Down
7 changes: 3 additions & 4 deletions src/Compiler/CodeGen/IlxGen.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4921,7 +4921,7 @@ and GenIntegerForLoop cenv cgbuf eenv (spFor, spTo, v, e1, dir, e2, loopBody, st

let stepConst =
match stepExpr with
| Some(Expr.Const (Const.Int32 i, _, _)) when i <> 0 -> Some i
| Some (Expr.Const (Const.Int32 i, _, _)) when i <> 0 -> Some i
| _ -> None

let finishIdx, stepIdx, eenvinner =
Expand Down Expand Up @@ -4999,7 +4999,7 @@ and GenIntegerForLoop cenv cgbuf eenv (spFor, spTo, v, e1, dir, e2, loopBody, st
// v++ or v--
GenGetLocalVal cenv cgbuf eenvinner e2.Range v None

match stepExpr with
match stepExpr with
| None ->
match dir with
| FSharpForLoopUp
Expand Down Expand Up @@ -5034,7 +5034,7 @@ and GenIntegerForLoop cenv cgbuf eenv (spFor, spTo, v, e1, dir, e2, loopBody, st

GenGetLocalVal cenv cgbuf eenvinner e2.Range v None

match stepExpr with
match stepExpr with
| None ->
match dir with
| FSharpForLoopUp
Expand Down Expand Up @@ -5078,7 +5078,6 @@ and GenIntegerForLoop cenv cgbuf eenv (spFor, spTo, v, e1, dir, e2, loopBody, st
CmpThenBrOrContinue(pop 2, [ I_brcmp(BI_bge, inner.CodeLabel) ])
|> GenSequel cenv eenv.cloc cgbuf


// .finish - loop-exit here
CG.SetMarkToHere cgbuf finish

Expand Down