Deleting some old tests#13783
Closed
psfinaki wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Discussed this with @KevinRansom, we'll keep these ones for now. We should have another iteration of proper unit testing of all these features to hopefully get rid of the FSharpQA stuff for good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arguably not needed after #13765
Apart from having a complicated way of execution, these tests don't add much value since they are basically testing a thing created specifically for tests, not a real customer-facing behavior (which would be help option, for example).
Also deprecating related
--dumpAllCommandLineOptionsoption - we likely cannot remove it for good as it'd technically break backward compatibility (although not documented one).