Workaround for #15972#15982
Merged
Merged
Conversation
abonie
approved these changes
Sep 15, 2023
0101
approved these changes
Sep 15, 2023
Member
Author
|
Alright, some of the diagnostics tests are expectedly failing, I will either fix them or disable (since we'll likely revert the change once roslyn has a fix). |
…ail once we rollback the change, but forget to rollback tests
Member
Author
|
Ok, not proud of the fix, but it will fail if we rollback the workaround but forget tests. |
T-Gro
added a commit
that referenced
this pull request
May 28, 2026
The workaround referenced in #15982 is no longer in place, so the *_HACK_PLEASE_REFER_TO_COMMENT_INSIDE methods are now identical to their non-suffixed counterparts. Drop the duplicate definitions and route the call sites to the existing VerifyErrorBetweenMarkers / VerifyErrorAtMarker helpers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After talking to @0101, we decided to make a workaround for #15972 by not excluding parsing/syntax errors from semantic ones, just in case if proper fix doesn't make it to P3.
Worst case scenario, parsing errors will be doubled.
It shows errors right now: