Skip to content

Remove superfluous rec keywords and untangle some functions #16544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T-Gro merged 9 commits into from
Jan 24, 2024
Merged

Remove superfluous rec keywords and untangle some functions #16544

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f60b1b0
remove some superfluous rec keywords and untangle two functions that …
dawedawe Jan 17, 2024
9fe074a
two more in Optimizer.fs
dawedawe Jan 17, 2024
735b32c
one more in CheckExpressions.fs
dawedawe Jan 17, 2024
f2957a1
two more in IlxGen.fs
dawedawe Jan 17, 2024
6b3a353
untangle some functions in TypedTreeOps.fs
dawedawe Jan 17, 2024
fb4c54d
inline accFreeExnRef
dawedawe Jan 18, 2024
09c18d9
Merge branch 'main' into cleanup_some_recs
dawedawe Jan 19, 2024
48958bb
one more in TypedTreeOps.fs
dawedawe Jan 19, 2024
d9e3773
one more in Optimizer.fs
dawedawe Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
one more in Optimizer.fs
  • Loading branch information
@dawedawe
dawedawe committed Jan 22, 2024
commit d9e37734ccf3a55b82a91dc55b5eadfd88acb339
4 changes: 2 additions & 2 deletions src/Compiler/Optimize/Optimizer.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,11 +1454,11 @@ let AbstractExprInfoByVars (boundVars: Val list, boundTyVars) ivalue =
| UnknownValue -> ivalue
| SizeValue (_vdepth, vinfo) -> MakeSizedValueInfo (abstractExprInfo vinfo)

and abstractValInfo v =
let abstractValInfo v =
{ ValExprInfo=abstractExprInfo v.ValExprInfo
ValMakesNoCriticalTailcalls=v.ValMakesNoCriticalTailcalls }

and abstractModulInfo ss =
let rec abstractModulInfo ss =
{ ModuleOrNamespaceInfos = ss.ModuleOrNamespaceInfos |> NameMap.map (InterruptibleLazy.force >> abstractModulInfo >> notlazy)
ValInfos = ss.ValInfos.Map (fun (vref, e) ->
check vref (abstractValInfo e) ) }
Expand Down