Skip to content

Bugfix :: Nullness :: Add warnings for instantiations of (T|null) which are not allowed in F# (frequent at Deserialize from S.T.Json) #18057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psfinaki merged 9 commits into from
Dec 4, 2024
Merged

Bugfix :: Nullness :: Add warnings for instantiations of (T|null) which are not allowed in F# (frequent at Deserialize from S.T.Json) #18057

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
62608a5
basic check
T-Gro Nov 25, 2024
d6638f5
Merge branch 'main' into 17951-nullness-issue---no-warning-when-nulla…
T-Gro Nov 25, 2024
69fcf79
handle units of measure
T-Gro Nov 25, 2024
e344ffe
fantomas
T-Gro Nov 25, 2024
07bd536
test expectation adjusted
T-Gro Nov 25, 2024
65b79c9
Update src/Compiler/FSComp.txt
T-Gro Nov 26, 2024
31476ad
change wording
T-Gro Nov 26, 2024
5567d00
Merge branch 'main' into 17951-nullness-issue---no-warning-when-nulla…
T-Gro Nov 26, 2024
199b7c6
Merge branch 'main' into 17951-nullness-issue---no-warning-when-nulla…
T-Gro Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/Compiler/FSComp.txt 
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
  • Loading branch information
@T-Gro @vzarytovskii
T-Gro and vzarytovskii authored Nov 26, 2024
commit 65b79c9cd74eee1b2dfef0502f9e1f10c3a7155d
2 changes: 1 addition & 1 deletion src/Compiler/FSComp.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1538,7 +1538,7 @@ tcPassingWithoutNullToNonNullQuickAP,"You can remove this |NonNullQuick| pattern
tcPassingWithoutNullTononNullFunction,"You can remove this `nonNull` assertion."
3263,tcNullableToStringOverride,"With nullness checking enabled, overrides of .ToString() method must return a non-nullable string. You can handle potential nulls via the built-in string function."
3264,tcDowncastFromNullableToWithoutNull,"Nullness warning: Downcasting from '%s' into '%s' can introduce unexpected null values. Cast to '%s|null' instead or handle the null before downcasting."
3265,tcDisallowedNullableApplication,"Application of method '%s' attempted to create a disallowed nullable (T|null) type for '%s'. Such type will not report nulness warnings correctly."
3265,tcDisallowedNullableApplication,"Application of method '%s' attempted to create a disallowed nullable reference type ('T | null) for '%s'. Nullness warnings won't be reported correctly for such types."
3268,csNullNotNullConstraintInconsistent,"The constraints 'null' and 'not null' are inconsistent"
3271,tcNullnessCheckingNotEnabled,"The 'nullness checking' language feature is not enabled. This use of a nullness checking construct will be ignored."
csTypeHasNullAsTrueValue,"The type '%s' uses 'null' as a representation value but a non-null type is expected"
Expand Down