Skip to content

Add regression test: #6715, land is a valid identifier#19478

Merged
T-Gro merged 1 commit intomainfrom
regression-test/issue6715
Mar 31, 2026
Merged

Add regression test: #6715, land is a valid identifier#19478
T-Gro merged 1 commit intomainfrom
regression-test/issue6715

Conversation

@T-Gro
Copy link
Copy Markdown
Member

@T-Gro T-Gro commented Mar 24, 2026

Adds a regression test for #6715

Verifies that land, lor, lxor, lsl, lsr, and asr can be used as valid identifiers after the ML compatibility removal in PR #19143. Previously, let land = 3 would produce the confusing FS0010 "Unexpected infix operator in binding" error.

Fixes #6715

@T-Gro T-Gro requested a review from a team as a code owner March 24, 2026 10:45
@T-Gro T-Gro added NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes AI-Issue-Regression-PR PR adding regression test for a closed issue labels Mar 24, 2026
@T-Gro T-Gro requested a review from abonie March 24, 2026 10:45
@T-Gro T-Gro enabled auto-merge (squash) March 24, 2026 10:45
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Mar 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2026

Commit pushed: 277b190

Generated by Regression PR Shepherd

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

Commit pushed: d753772

Generated by Regression PR Shepherd

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

🤖 This is an automated response from Regression PR Shepherd.

Fixed the merge conflict (Category B0). The PR branch had a bad merge conflict resolution that accidentally dropped the Issue 15655 test when the PR was merged with main.

What happened: When the PR author merged main into this branch, both the PR and main had added tests to DiagnosticRegressionTests.fs. The conflict was incorrectly resolved by replacing the Issue 15655 test with the Issue 6715 test instead of keeping both.

The fix (commit pushed): Checked out the current main version of the file and inserted the Issue 6715 test at the top, so now both Issue 6715 and Issue 15655 tests are present.

This should clear the action_required / dirty CI state and allow a clean CI run.

Generated by Regression PR Shepherd · ◷

@github-actions github-actions bot mentioned this pull request Mar 31, 2026
Open
12 tasks
@T-Gro
Add regression test for #6715: land is a valid identifier
c6b70d5 
Verifies that land, lor, lxor, lsl, lsr, and asr can be used as valid
identifiers after the ML compatibility removal in PR #19143.

Fixes #6715

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-Gro T-Gro force-pushed the regression-test/issue6715 branch from 58754d6 to c6b70d5 Compare March 31, 2026 10:26
@T-Gro T-Gro merged commit 1775f42 into main Mar 31, 2026
48 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling Mar 31, 2026
Copilot AI pushed a commit that referenced this pull request Mar 31, 2026
@T-Gro @abonie
Add regression test for #6715: land is a valid identifier (#19478)
58167c1 
Verifies that land, lor, lxor, lsl, lsr, and asr can be used as valid
identifiers after the ML compatibility removal in PR #19143.

Fixes #6715

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
Copilot AI pushed a commit that referenced this pull request Mar 31, 2026
@T-Gro @abonie
Add regression test for #6715: land is a valid identifier (#19478)
3009471 
Verifies that land, lor, lxor, lsl, lsr, and asr can be used as valid
identifiers after the ML compatibility removal in PR #19143.

Fixes #6715

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
Copilot AI pushed a commit that referenced this pull request Mar 31, 2026
@T-Gro @abonie
Add regression test for #6715: land is a valid identifier (#19478)
c09de33 
Verifies that land, lor, lxor, lsl, lsr, and asr can be used as valid
identifiers after the ML compatibility removal in PR #19143.

Fixes #6715

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
This was referenced Mar 31, 2026
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonie abonie abonie approved these changes

Assignees

No one assigned

Labels

AI-Issue-Regression-PR PR adding regression test for a closed issue NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"land" reserved keyword error message

2 participants

@T-Gro @abonie