Conversation
…t location Verifies that FSharpMemberOrFunctionOrValue.DeclarationLocation for a property used as T().Prop points to the property name, not the get accessor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
abonie
approved these changes
Mar 31, 2026
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Fixes #16056
Adds a regression test verifying that
FSharpMemberOrFunctionOrValue.DeclarationLocationfor a property used at a call site (T().Prop) correctly points to the property name identifier in the declaration — not to thegetaccessor.Before the fix (regressed in #15589), the
DeclarationLocationpointed to thegetkeyword range (column ~35) instead of thePropidentifier range (column 15).Test added:
Auto property DeclarationLocation points to property name, not get accessorintests/FSharp.Compiler.Service.Tests/Symbols.fs