Debug: rework conditional erasure, fix stepping over literals#19897
Open
auduchinok wants to merge 6 commits into
Open
Debug: rework conditional erasure, fix stepping over literals#19897auduchinok wants to merge 6 commits into
auduchinok wants to merge 6 commits into
Conversation
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
Member
Author
|
@T-Gro The release notes comment is now missing the link to open the online editor. Could we have it back, please? 🙂 |
auduchinok
force-pushed
the
debug-sequencePoint-erased
branch
from
5214f29 to
e1a3f86
Compare
github-actions
Bot
added
⚠️ Affects-Compiler-Output
Contributor
|
🔍 Tooling Safety Check — Affects-Bootstrap, Affects-Compiler-Output
|
auduchinok
changed the title
Member
Author
Ah, my bad. The branch already had the release notes from the other PR, that's why there was no link. |
Member
Author
|
Please merge #19894 first. |
Add `isHidden` to `DebugPointAtLeafExpr.Yes` to express it explicitly in the typed tree Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
auduchinok
force-pushed
the
debug-sequencePoint-erased
branch
from
aa147a5 to
773d15c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #19894.
Removes an old workaround for conditional call erasure that could prevent generating sequence points for unit expressions. Adds a new helper for marking hidden sequence points. Restores stepping over simple literal bindings that got broken with
realsig+.