Include System.Buffers in vsix#8277
Merged
KevinRansom merged 4 commits intodotnet:masterfrom Jan 22, 2020
Merged
Conversation
TIHan
added
the
Impact-High
KevinRansom
approved these changes
Jan 22, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Include System.Buffers in vsix * Updated nuspec with System.Buffers * Add buffers to output group Co-authored-by: Kevin Ransom (msft) <codecutter.fsharp@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@KevinRansom I realized when I added System.Buffers as a dep, it is not being included in the VSIX. Also need to make sure it's in the nuspec.
Is this all the right way to do this? I keep trying to build and deploy and it's still not putting the
System.Buffers.dllin the VSIX for some reason. Is there another place I am not aware of?