Skip to content

The walking dead version of Fixes #9217 #9363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 4 commits into from
Jun 2, 2020
Merged

The walking dead version of Fixes #9217 #9363

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc61889
Fix #9217 -- Nuget #r references do not resolve assemblies referenced…
KevinRansom May 31, 2020
fab58a8
Regression test
KevinRansom Jun 1, 2020
9545d72
Feedback
KevinRansom Jun 1, 2020
09c748a
triple quote
KevinRansom Jun 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Regression test
  • Loading branch information
@KevinRansom
KevinRansom committed Jun 1, 2020
commit fab58a819b001b1cb5e2be48e90a66e308f7e768
24 changes: 24 additions & 0 deletions tests/FSharp.Compiler.Private.Scripting.UnitTests/FSharpScriptTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,3 +302,27 @@ let x =
"
script.Eval(code) |> ignoreValue
Assert.False(foundInner)

[<Test>]
member _.``Script with nuget package that yields out of order dependencies works correctly``() =
// regression test for: https://github.com/dotnet/fsharp/issues/9217

let code = """
#r "nuget: FParsec,1.1.1"

open FParsec

let test p str =
match run p str with
| Success(result, _, _) ->
printfn "Success: %A" result
true
| Failure(errorMsg, _, _) ->
printfn "Failure: %s" errorMsg
false
test pfloat "1.234"
"""
use script = new FSharpScript(additionalArgs=[|"/langversion:preview"|])
let opt = script.Eval(code) |> getValue
let value = opt.Value
Assert.AreEqual(true, value.ReflectionValue :?> bool)