Support macos-arm64 - #129
Merged
Merged
Conversation
On macos-arm64 uname -m returns arm64. Update get_machine_architecture()
Contributor
Author
|
This assumes the user wants the native runtime architecture. macos-arm64 can also emulate macos-x86_64 with Rosetta2. Under Rosetta2 shell emulation, |
Contributor
|
Hi @sdmaclea |
bekir-ozturk
approved these changes
Jan 21, 2021
AR-May
approved these changes
Jan 21, 2021
Contributor
Author
I think this is the right fix. MacOS Rosetta2 emulation just complicates the usage of the script, but it seems logical. |
Contributor
Author
|
I don't have write privileges in this repo. Someone else will need to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macos-arm64
uname -mreturnsarm64. Updateget_machine_architecture()