Skip to content

PVP workaround for system.drawing.common removal - #15876

Merged
MichaelSimons merged 1 commit into
dotnet:mainfrom
MichaelSimons:SDC-removal
Mar 21, 2023
Merged

PVP workaround for system.drawing.common removal#15876
MichaelSimons merged 1 commit into
dotnet:mainfrom
MichaelSimons:SDC-removal

Conversation

@MichaelSimons

Copy link
Copy Markdown
Member

This PR contains the following changes:

  1. Added a more robust workaround for System.Drawing.Common being removed from Runtime than what was added in Add System.Common.Drawing prebuilt #15868. As I result of this, I removed the System.Drawing.Common prebuilt added in that PR.
  2. Added the following prebuilts - Eventually these should be new SBRPs but it required the 7.0 targeting pack which we do not want to add yet until all repos have been upgraded to target net8.0.
  3. System.Drawing.Common,7.0.0
  4. Microsoft.Win32.SystemEvents,7.0.0

Once merged, I will log a follow-up issue to cleanup this workaround as part of the preview 3 public PR.

@MichaelSimons
MichaelSimons requested a review from a team as a code owner March 20, 2023 22:20
@MichaelSimons

Copy link
Copy Markdown
Member Author

I will backport this to Preview 3 once approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants