Bump 3.0 packs to 3.0.1 as appropriate - #5698
Merged
wtgodbe merged 1 commit intoNov 16, 2019
Merged
Conversation
wtgodbe
approved these changes
Nov 16, 2019
Member
|
Approved for 3.1.100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The 3.1 SDK does not use 3.0.1 runtime and targeting packs as appropriate when targeting 3.0.
Customer impact
Regression
From customer perspective, yes, as this will be perceived as scenarios 1 and 2 working in 3.0.101 SDK and not 3.1.100 SDK.
Risk
Low.
Tests
Diffed the bundled versions props file between 3.0.101 and 3.1.100 to confirm that the 3.0 sections are now identical. dotnet/sdk tests that run in CI stressed this scenario as well, as evidenced by needing to add a nuget feed to find 3.0.1 runtime pack once this change was applied (The challenge is that 3.0.1 and 3.1.0 are shipping days apart so 3.0.1 assets aren't on nuget.or yet.)