Enable win-arm64 as known RID for AspNetCore - #8173
Conversation
|
cc @tommcdon |
sfoslund
left a comment
sfoslund
left a comment
There was a problem hiding this comment.
Sorry for the delayed review, thank you for your patience.
|
|
||
| <AspNetCore31RuntimePackRids Include="@(AspNetCore30RuntimePackRids)" /> | ||
| <AspNetCoreRuntimePackRids Include="@(AspNetCore31RuntimePackRids)" /> | ||
| <AspNetCoreRuntimePackRids Include="@(AspNetCore31RuntimePackRids);win-arm64" /> |
There was a problem hiding this comment.
Should this be a supported RID for all versions or just 5.0+? Can we create another itemgroup to include this in and follow the pattern defined by AspNetCore30RuntimePackRids and AspNetCore31RuntimePackRids?
There was a problem hiding this comment.
Just for 5.0. Should this be renamed then to AspNetCore5.0RuntimePackRids? It just seemed that the tip has the version-less element so I followed that.
There was a problem hiding this comment.
Yes, I think creating a AspNetCore50RuntimePackRids item group makes sense here.
|
@hoyosjs are you still working on this pr? |
|
@marcpopMSFT yes, although I was planning to merge it with the ARM64 PR I have coming up for the installers so it can be more easily ported to the release trains. Any opinions on that? |
|
What do you mean by "release trains"? RC2 is closing soon. You need to finish it before 9/24 to catch 5.0 release |
|
Closing in favor of #8470 |
4 participants
No description provided.