[master] Update dependencies from dotnet/arcade - #855
Merged
joperezr merged 4 commits intoNov 21, 2019
Conversation
…118.10 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19568.10 - Microsoft.DotNet.GenAPI - 5.0.0-beta.19568.10 - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19568.10
joperezr
reviewed
Nov 20, 2019
joperezr
left a comment
joperezr
left a comment
Member
There was a problem hiding this comment.
Changes looks good but an arcade change broke the build. Waiting for dotnet/arcade#4401 to get ingested since that is the fix.
…119.6 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19569.6 - Microsoft.DotNet.GenAPI - 5.0.0-beta.19569.6 - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19569.6
Member
|
@tmat looks like your latest fix didn't work here, it created a circular dependency for the Build target. |
…120.3 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19570.3 - Microsoft.DotNet.GenAPI - 5.0.0-beta.19570.3 - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19570.3
…120.6 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19570.6 - Microsoft.DotNet.GenAPI - 5.0.0-beta.19570.6 - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19570.6
joperezr
approved these changes
Nov 21, 2019
joperezr
deleted the
darc-master-c57daf35-90e4-49b3-a164-a64d1d2ad51b
branch
November 21, 2019 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/arcade