This repository was archived by the owner on Jul 6, 2026. It is now read-only.
Migrate projects to SDK style / netstandard2.0. - #507
Merged
Conversation
jpobst
force-pushed
the
sdk-csproj
branch
7 times, most recently
from
October 18, 2019 21:28
dc155f1 to
ab2379b
Compare
jpobst
marked this pull request as ready for review
October 29, 2019 16:05
jpobst
changed the title
jonpryor
reviewed
Oct 29, 2019
| T: Java.Interop.JavaException | ||
| T: Java.Interop.JavaObject | ||
| # Warning is due to using `nameof()`, without .mdb symbols gendarme doesn't know it's not a constant | ||
| T: Java.Interop.JniNativeMethodRegistrationArguments |
Contributor
There was a problem hiding this comment.
The warning is because the field is readonly as opposed to const. We certainly could use nameof() with a const, it would just require that we use operator+ to remove the warning:
const string invalidStateMessage = nameof(JniNativeMethodRegistrationArguments)" + " state is invalid. Please use constructor with parameters.";Other than being "uglier", perhaps this is what we should do? Would likely result in (slightly) less CPU time/etc.
Contributor
There was a problem hiding this comment.
Related: Why did I not call that InvalidStateMessage? :-/
jpobst
force-pushed
the
sdk-csproj
branch
2 times, most recently
from
October 31, 2019 21:10
36c8180 to
c149619
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should get all the libraries over to
netstandard2.0. Test projects aren't converted yet. I prefer to do this in smaller chunks and make sure each part works. ;)