Replacing Custom Oses with versionless rids - #254
Closed
Anipik wants to merge 4 commits into
Closed
Conversation
ericstj
reviewed
Mar 17, 2020
Author
|
@ericstj i suggest merging this after the runtime PR, bcoz otherwise it will lead to all PRs in the runtime having failed formatting job. or maybe we can merge both of them together. |
Member
|
What about other release branches (5.0 and 3.x) which consume jitutils from master? |
ericstj
reviewed
Mar 17, 2020
ericstj
reviewed
Mar 17, 2020
|
|
||
| SunOS) | ||
| __HostOS=SunOS | ||
| __HostOS=sunos |
Member
There was a problem hiding this comment.
Haven't seen this RID before. Is it going to be a problem that we don't have a mapping for this in runtime.json?
Member
|
The diff looks reasonable to me, but I can't really sign off on this as I don't know the purpose of most of these files. |
Co-Authored-By: Eric StJohn <ericstj@microsoft.com>
Contributor
|
Closing this since dotnet/runtime#33315 was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relate runtime PR dotnet/runtime#33315
This change is required to enable to pass the win formatting leg.