CoreDisTools on Arm - #291
Merged
Merged
Conversation
echesakov
force-pushed
the
CoreDisTools-Arm
branch
3 times, most recently
from
September 22, 2020 23:35
f17377a to
e09e305
Compare
echesakov
force-pushed
the
CoreDisTools-Arm
branch
from
September 22, 2020 23:38
e09e305 to
38f1dca
Compare
…_TO_BUILD in build-coredistools.sh
…humb2MoveTopOpcode in coredistools.cpp
echesakov
force-pushed
the
CoreDisTools-Arm
branch
from
September 23, 2020 00:13
38f1dca to
daceefe
Compare
echesakov
marked this pull request as ready for review
September 23, 2020 18:00
Contributor
Author
|
@dotnet/jit-contrib PTAL |
BruceForstall
self-requested a review
September 23, 2020 18:12
BruceForstall
approved these changes
Sep 23, 2020
BruceForstall
left a comment
BruceForstall
left a comment
Contributor
There was a problem hiding this comment.
Looks great. Thanks!
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for proper recognition of movw/movt instructions pairs on Arm in
CorAsmDiff::nearDiff.In a case when such instructions pairs are compared, their immediates should not be compared independently. Instead their values should be used to reconstruct a 32-bit value that is loaded into a register and these reconstructed value should be compared either for identity or equality (with a user defined
Comparator).I tested this approach by
In both 2 and 3 there were no cases of false positives diffs between baseline and compared jits. (If this algorithm is disabled, almost every method becomes different according to
CorAsmDiff::nearDiffdue to some immediates - either movt or movw having different values).This PR also specifies
LLVM_DEFAULT_TARGET_TRIPLEto be Thumb2 not Arm and decreases number of platforms supported by each flavor of coredistools.