[release/6.0.2xx] Fix invalid cast of type parameter - #2643
Merged
Conversation
vitek-karas
approved these changes
Feb 23, 2022
jeffschwMSFT
approved these changes
Feb 24, 2022
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. We should take for consideration in 6.0.2xx
agocke
approved these changes
Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the fix @agocke made as part of #2540 to 6.0.2. Fixes #2642.
Customer Impact
Updating VS from 17 to 17.1 brings in a 6.0.2 SDK which causes the analyzer to crash on a project that previously worked, producing a warning. The warning also shows up in CI when using the 6.0.2 SDK, and fails the build with warnaserror. See details in #2642.
Testing
Unit tests confirmed the issue and the fix. This was originally discovered as part of running the analyzer over itself and the linker in #2523.
Risk
Very low risk - this turns a cast to a type check, and skips the case which used to throw an InvalidCastException.