|
public Double LearningRates = Defaults.LearningRates; |
Should this be LearningRate? The Options have it named wrongly.
The named parameter for the FastTree is named correctly as learningRate.
|
double learningRate = Defaults.LearningRates) |
It would be great if you can check the same with all the trainers and transforms. i.e the named parameters(in the method) resemble the Actual Property name(in the options). In my opinion these all should be consistent. In case of named params (camel case) and for actual Property (of course is pascal case)
machinelearning/src/Microsoft.ML.FastTree/FastTreeArguments.cs
Line 528 in 4bb3e00
Should this be LearningRate? The Options have it named wrongly.
The named parameter for the FastTree is named correctly as learningRate.
machinelearning/src/Microsoft.ML.FastTree/TreeTrainersCatalog.cs
Line 34 in 4bb3e00
It would be great if you can check the same with all the trainers and transforms. i.e the named parameters(in the method) resemble the Actual Property name(in the options). In my opinion these all should be consistent. In case of named params (camel case) and for actual Property (of course is pascal case)