AveragedPerceptron default iterations

[justinormont]

When changing AveragedPerceptron's default number of iterations from 1 to 10 in #5258, we missed one.

The main interface continues to default to 1 iteration:

Previous issues:

• [Meta Issue] Changing defaults #4749
• Updated AveragedPerceptron default iterations from 1 to 10 #5258

Code location

Default is set here:

machinelearning/src/Microsoft.ML.StandardTrainers/Standard/Online/AveragedPerceptron.cs

Line 172 in 5dbfd8a

int numberOfIterations = Options.AveragedDefault.NumberOfIterations)

Which originates from:

machinelearning/src/Microsoft.ML.StandardTrainers/Standard/Online/AveragedLinear.cs

Lines 108 to 113 in 5dbfd8a

	internal class AveragedDefault : OnlineLinearOptions.OnlineDefault
	{
	public const float LearningRate = 1;
	public const bool DecreaseLearningRate = false;
	public const float L2Regularization = 0;
	}

Which in-turn inherits its value from:

machinelearning/src/Microsoft.ML.StandardTrainers/Standard/Online/OnlineLinear.cs

Lines 62 to 65 in 5dbfd8a

	internal class OnlineDefault
	{
	public const int NumberOfIterations = 1;
	}

Possible fix

We may want to make a new class within AveragedPerceptron to hold its overrides:

        internal class AveragedPerceptronDefault : AveragedDefault
        { 
            public const float NumberOfIterations = 10; 
        } 

/cc @michaelgsharp

[michaelgsharp]

I think your idea of making a new class for just the AveragedPerceptron overrides is a good idea. I'll get to this soon.