Adding extensions for Hal learners. More namespace re-ogr. - #1370
Merged
Conversation
sfilipi
requested review from
Ivanidzo4ka,
TomFinley,
Zruty0,
artidoro and
singlis
October 24, 2018 23:54
Zruty0
reviewed
Oct 25, 2018
| /// <param name="features">The features colum.</param> | ||
| /// <param name="weights">The weights column.</param> | ||
| /// <param name="advancedSettings">Algorithm advanced settings.</param> | ||
| public static OlsLinearRegressionTrainer OrdinaryLeastSquare(this RegressionContext.RegressionTrainers ctx, |
Contributor
There was a problem hiding this comment.
Square [](start = 62, length = 6)
least squares is the term #Resolved
Zruty0
reviewed
Oct 25, 2018
| /// <param name="label">The label column.</param> | ||
| /// <param name="features">The features colum.</param> | ||
| /// <param name="advancedSettings">Algorithm advanced settings.</param> | ||
| public static SymSgdClassificationTrainer SymbolicSgd(this RegressionContext.RegressionTrainers ctx, |
Contributor
There was a problem hiding this comment.
Sgd [](start = 58, length = 3)
expand abbreviation? #Resolved
Zruty0
reviewed
Oct 25, 2018
| [assembly: LoadableClass(typeof(void), typeof(PcaTransform), null, typeof(SignatureEntryPointModule), PcaTransform.LoaderSignature)] | ||
|
|
||
| namespace Microsoft.ML.Runtime.Data | ||
| namespace Microsoft.ML.Transforms.PCA |
Contributor
There was a problem hiding this comment.
Transforms [](start = 23, length = 10)
you might want to refresh this since #1333 is in #Resolved
Zruty0
reviewed
Oct 25, 2018
| ] | ||
| }, | ||
| { | ||
| "Name": "Trainers.StochasticDualCoordinateAscentClassifier", |
Contributor
There was a problem hiding this comment.
StochasticDualCoordinateAscentClassifier [](start = 24, length = 40)
why is this gone? #Resolved
singlis
reviewed
Oct 25, 2018
| /// </summary> | ||
| /// <param name="ctx">The <see cref="RegressionContext"/>.</param> | ||
| /// <param name="label">The label column.</param> | ||
| /// <param name="features">The features colum.</param> |
Member
There was a problem hiding this comment.
colum [](start = 48, length = 5)
Column is misspelled - there are a number of places where this is copied. #Resolved
…s to the same namespace. Addressing the other PR issues.
sfilipi
commented
Oct 25, 2018
| pipeline.Add(new ColumnConcatenator(outputColumn: "Features", | ||
| "NumericalFeatures", "CategoryFeatures")); | ||
| pipeline.Add(new StochasticDualCoordinateAscentRegressor()); | ||
| // pipeline.Add(new StochasticDualCoordinateAscentRegressor()); |
Member
Author
There was a problem hiding this comment.
// pi [](start = 10, length = 6)
revert #Resolved
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #1318: more namespace re-org and catalog extensions.