Add Parquet symbols nuget package. - #145
Merged
Merged
Conversation
Add symbols package for ML.Parquet package. Put common NuGet package logic in props file. Fix dotnet#144
Anipik
reviewed
May 14, 2018
| <Content Include="$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\**\*" Pack="true" PackagePath="runtimes" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(IsSymbolsPackage)' != 'true'"> |
Contributor
There was a problem hiding this comment.
there will be some symbols with the extension .dll, this wont remove them
Member
Author
There was a problem hiding this comment.
what symbols have an extension of .dll?
Contributor
There was a problem hiding this comment.
Sorry, my bad I got confused.
Member
Author
|
@dotnet-bot test this please |
vieirandre
approved these changes
May 14, 2018
eerhardt
added a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
Add symbols package for ML.Parquet package. Put common NuGet package logic in props file. Fix dotnet#144
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add symbols package for ML.Parquet package.
Put common NuGet package logic in props file.
Fix #144