Fixes build errors on Windows when project path contains spaces - #196
Conversation
|
|
|
@dotnet-bot test Windows_NT Release |
|
|
||
| set VSCMD_START_DIR="%__currentScriptDir%" | ||
|
|
||
| set VSCMD_START_DIR=%__currentScriptDir% |
There was a problem hiding this comment.
Why is this set different than the 2 below? For example, the two below have the format set "name=%__currentScriptDir%" where this one doesn't have the surrounding double-quotes.
There was a problem hiding this comment.
You're right. I've added the quotes again (also around the variable for consistency).
| <!-- Run script that invokes Cmake to create VS files, and then calls msbuild to compile them --> | ||
| <Message Text="$(MSBuildProjectDirectory)\build.cmd $(BuildArgs)" Importance="High"/> | ||
| <Exec Command="$(MSBuildProjectDirectory)\build.cmd $(BuildArgs)" /> | ||
| <Exec Command=""$(MSBuildProjectDirectory)\build.cmd" $(BuildArgs)" /> |
There was a problem hiding this comment.
It appears the unix build has the same issue. Would it be possible to fix the Unix build as well?
There was a problem hiding this comment.
Certainly, I have some time in the end of the week. Shall I put this in a new pull request, so the Windows fix can already be put to use now?
There was a problem hiding this comment.
Yes, it is totally fine with me to create another PR for that.
tincann
changed the title
ghost
locked as resolved and limited conversation to collaborators
4 participants
Fixes #191
The problem seemed to be that
%~dp0was used in the batch scripts without proper quoting.