Stop using System.ComponentModel.Composition - #2569
Merged
Merged
Conversation
eerhardt
requested review from
Ivanidzo4ka,
TomFinley,
sfilipi and
yaeldekel
February 15, 2019 17:47
eerhardt
commented
Feb 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #2569 +/- ##
==========================================
+ Coverage 71.57% 71.58% +<.01%
==========================================
Files 800 802 +2
Lines 141789 141835 +46
Branches 16107 16113 +6
==========================================
+ Hits 101488 101526 +38
- Misses 35851 35859 +8
Partials 4450 4450
|
TomFinley
reviewed
Feb 15, 2019
TomFinley
reviewed
Feb 15, 2019
TomFinley
reviewed
Feb 15, 2019
TomFinley
reviewed
Feb 15, 2019
TomFinley
left a comment
TomFinley
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good @eerhardt, thank you for working on this. My only real major comment is the naming, something shouldn't call itself a transformer factory unless it is a factory that makes transformers, and this definitely is not that. 😄 But aside from that, looks great, thank you.
This was referenced Feb 20, 2019
Replace our MEF usage, which is only used by custom mapping transforms, with the ComponentCatalog class. Fix dotnet#1595 Fix dotnet#2422
Member
Author
|
OK, @TomFinley, I've renamed the classes. Can you take a look? @Ivanidzo4ka @yaeldekel - can I get a second pair of eyes? |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace our MEF usage, which is only used by custom mapping transforms, with the ComponentCatalog class.
Fix #1595
Fix #2422