Update to coverlet 2.6.0 by sharwell · Pull Request #2843 · dotnet/machinelearning

sharwell · 2019-03-05T01:08:33Z

No description provided.

codecov · 2019-03-05T02:07:36Z

Codecov Report

Merging #2843 into master will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2843      +/-   ##
==========================================
+ Coverage   71.81%   72.17%   +0.35%     
==========================================
  Files         812      796      -16     
  Lines      142659   141949     -710     
  Branches    16090    16042      -48     
==========================================
  Hits       102450   102450              
+ Misses      35826    35117     -709     
+ Partials     4383     4382       -1

Flag	Coverage Δ
#Debug	`72.17% <ø> (+0.35%)`	⬆️
#production	`67.96% <ø> (ø)`	⬆️
#test	`88.32% <ø> (+2.08%)`	⬆️

Impacted Files	Coverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs	`84.7% <0%> (-0.21%)`	⬇️
test/Microsoft.ML.Benchmarks/Numeric/Ranking.cs
...st/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs
...t/Microsoft.ML.Benchmarks/PredictionEngineBench.cs
...s/StochasticDualCoordinateAscentClassifierBench.cs
...est/Microsoft.ML.Benchmarks/Helpers/EmptyWriter.cs
test/Microsoft.ML.Benchmarks/CacheDataViewBench.cs
test/Microsoft.ML.Benchmarks/Harness/Metrics.cs
test/Microsoft.ML.Benchmarks/Helpers/Errors.cs
test/Microsoft.ML.Benchmarks/RffTransform.cs
... and 8 more

TomFinley · 2019-03-05T15:22:10Z

If I pick a code coverage run arbitrarily, I see #2808 finished in 38m 13s. Yours finished in 23m 36s. That's a very positive perf difference!

TomFinley

Thank you @sharwell, at least at first glance this seems quite positive!

sharwell · 2019-03-05T15:54:56Z

@TomFinley it's a substantial improvement in time, but some of the data seems to be missing. I'm still investigating.

sharwell · 2019-03-10T16:03:38Z

-    <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
-    <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
+    <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
+    <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />


📝 This is an attempt to address a change in the way numbers were appearing in the new reports. For some reason, the file submitted to codecov had two copies of each source file. The first copy referenced the file using the build machine path, and the second referenced the file using a Source Link path. Prior reports submitted to codecov appeared to only contain the latter, so I'm attempting to use a filter to address the problem.

<class name="Microsoft.ML.StaticPipe.LdaFitResult" filename="D:\a\1\s\src\Microsoft.ML.StaticPipe\LdaStaticExtensions.cs" line-rate="0" branch-rate="1" complexity="NaN"> <methods> <method name=".ctor" signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)" line-rate="0" branch-rate="1"> <line number="24" hits="0" branch="false" /> <line number="25" hits="0" branch="false" /> <line number="26" hits="0" branch="false" /> <line number="27" hits="0" branch="false" /> </method> </methods> <lines> <line number="24" hits="0" branch="false" /> <line number="25" hits="0" branch="false" /> <line number="26" hits="0" branch="false" /> <line number="27" hits="0" branch="false" /> </lines> </class> <class name="Microsoft.ML.StaticPipe.LdaFitResult" filename="https://raw.githubusercontent.com/dotnet/machinelearning/d495bb4c7a58c459e753b9de3d0895c188468b58/src/Microsoft.ML.StaticPipe/LdaStaticExtensions.cs" line-rate="1" branch-rate="1" complexity="NaN"> <methods> <method name=".ctor" signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)" line-rate="1" branch-rate="1"> <line number="24" hits="1" branch="false" /> <line number="25" hits="1" branch="false" /> <line number="26" hits="1" branch="false" /> <line number="27" hits="1" branch="false" /> </method> </methods> <lines> <line number="24" hits="1" branch="false" /> <line number="25" hits="1" branch="false" /> <line number="26" hits="1" branch="false" /> <line number="27" hits="1" branch="false" /> </lines> </class>

sharwell · 2019-03-10T16:54:24Z

This should be ready for review. The changes to coverage were primarily the following:

Microsoft.ML.Benchmarks and Microsoft.ML.Benchmarks.Tests are no longer reported. These files had no coverage previously.
~~Microsoft.ML.FSharp.Tests is no longer reported; the reportgenerator file filter might need to be updated to include it~~ Should be fixed now

The other coverage changes appear to be normal non-determinism in the coverage runs.

sharwell · 2019-03-10T22:37:19Z

For some reason the button to move this from a draft pull request to a normal pull request is missing here...

TomFinley · 2019-03-10T23:57:40Z

For some reason the button to move this from a draft pull request to a normal pull request is missing here...

Interesting. Maybe it's one of those things that somehow needs write access? But that doesn't make sense. Anyway, I pushed the button...

codemzs

codemzs · 2019-03-12T22:39:13Z

Thanks, @sharwell !

* include coverlet.msbuild 2.5.1 * add targets and coverage group * mock dotnet/machinelearning#2843 * Hook coverlet up to the 'RunTests' target * Upload data to codecov.io * Add code coverage badge to the README * Add clarifying comments for code coverage configuration * Move coverage upload after pick/sign/publish

sharwell force-pushed the update-coverlet branch from 30dc9de to 59eac50 Compare March 5, 2019 01:27

sharwell force-pushed the update-coverlet branch 2 times, most recently from e7a3e4b to 953ae39 Compare March 5, 2019 13:57

TomFinley requested a review from codemzs March 5, 2019 15:17

TomFinley reviewed Mar 5, 2019

View reviewed changes

Comment thread test/Directory.Build.props

TomFinley approved these changes Mar 5, 2019

View reviewed changes

zsd4yr pushed a commit to dotnet/winforms that referenced this pull request Mar 8, 2019

mock dotnet/machinelearning#2843

562722b

sharwell force-pushed the update-coverlet branch 2 times, most recently from c032056 to e9758e2 Compare March 9, 2019 23:22

sharwell commented Mar 10, 2019

View reviewed changes

sharwell force-pushed the update-coverlet branch from dcea8df to 8cc7490 Compare March 10, 2019 17:03

TomFinley marked this pull request as ready for review March 10, 2019 23:56

TomFinley requested a review from shauheen March 10, 2019 23:58

sharwell mentioned this pull request Mar 11, 2019

VSTest stops process execution early microsoft/vstest#1900

Closed

sharwell commented Mar 11, 2019

View reviewed changes

Comment thread build/ci/phase-template.yml Outdated

Update to coverlet 2.6.0

faea7b3

sharwell force-pushed the update-coverlet branch from b72d225 to 7f88d7a Compare March 11, 2019 21:51

Only include SourceLink source in coverage report

67524ea

sharwell force-pushed the update-coverlet branch from 7f88d7a to 67524ea Compare March 11, 2019 21:51

codemzs approved these changes Mar 12, 2019

View reviewed changes

codemzs merged commit 6e1291a into dotnet:master Mar 12, 2019

sharwell deleted the update-coverlet branch March 12, 2019 22:49

ghost locked as resolved and limited conversation to collaborators Mar 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update to coverlet 2.6.0 - #2843

Update to coverlet 2.6.0#2843
codemzs merged 2 commits into
dotnet:masterfrom
sharwell:update-coverlet

sharwell commented Mar 5, 2019

Uh oh!

codecov Bot commented Mar 5, 2019 •

edited

Loading

Uh oh!

Uh oh!

TomFinley commented Mar 5, 2019 •

edited

Loading

Uh oh!

TomFinley left a comment

Uh oh!

sharwell commented Mar 5, 2019

Uh oh!

sharwell Mar 10, 2019 •

edited

Loading

Uh oh!

sharwell commented Mar 10, 2019 •

edited

Loading

Uh oh!

sharwell commented Mar 10, 2019

Uh oh!

TomFinley commented Mar 10, 2019

Uh oh!

Uh oh!

codemzs left a comment

Uh oh!

codemzs commented Mar 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sharwell commented Mar 5, 2019

Uh oh!

codecov Bot commented Mar 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

TomFinley commented Mar 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomFinley left a comment

Choose a reason for hiding this comment

Uh oh!

sharwell commented Mar 5, 2019

Uh oh!

sharwell Mar 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sharwell commented Mar 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sharwell commented Mar 10, 2019

Uh oh!

TomFinley commented Mar 10, 2019

Uh oh!

Uh oh!

codemzs left a comment

Choose a reason for hiding this comment

Uh oh!

codemzs commented Mar 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Mar 5, 2019 •

edited

Loading

TomFinley commented Mar 5, 2019 •

edited

Loading

sharwell Mar 10, 2019 •

edited

Loading

sharwell commented Mar 10, 2019 •

edited

Loading