Binary LR samples using T4 templates - #3099
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3099 +/- ##
==========================================
+ Coverage 72.52% 72.52% +<.01%
==========================================
Files 808 808
Lines 144665 144665
Branches 16198 16198
==========================================
+ Hits 104913 104916 +3
+ Misses 35342 35338 -4
- Partials 4410 4411 +1
|
Codecov Report
@@ Coverage Diff @@
## master #3099 +/- ##
==========================================
- Coverage 72.52% 72.51% -0.01%
==========================================
Files 808 808
Lines 144665 144665
Branches 16198 16198
==========================================
- Hits 104913 104907 -6
- Misses 35342 35346 +4
- Partials 4410 4412 +2
|
shmoradims
reviewed
Mar 26, 2019
| Label = label, | ||
| // Create random features that are correlated with the label. | ||
| // For data points with false label, the feature values are slightly increased by adding a constant. | ||
| Features = Enumerable.Repeat(label, 50).Select(x => x ? randomFloat() : randomFloat() + 0.03f).ToArray() |
There was a problem hiding this comment.
0.03f [](start = 108, length = 5)
The accuracy is low. We want samples to ideally have 80%+ accuracy. Can we increase this to 0.1 and see how much accuracy improves. If so, let's keep tree samples with old 0.03f value, and increase it for less powerful trainers like LogisticRegression. #Resolved
shmoradims
reviewed
Mar 26, 2019
|
|
||
| namespace Microsoft.ML.Samples.Dynamic.Trainers.BinaryClassification | ||
| { | ||
| public static class LogisticRegressionWithOptions |
There was a problem hiding this comment.
LogisticRegressionWithOptions [](start = 24, length = 29)
please make sure the sample is added to the xml documentation for BinaryClassification.Trainers.LbfgsLogisticRegression. #Resolved
shmoradims
reviewed
Mar 26, 2019
| @@ -0,0 +1,29 @@ | |||
| <#@ include file="BinaryClassification.ttinclude"#> | |||
| <#+ | |||
| string ClassName="LogisticRegression"; | |||
There was a problem hiding this comment.
LogisticRegression [](start = 18, length = 18)
let's rename class to LbfgsLogisticRegression to match the API. also plz rename the other sample to LbfgsLogisticRegressionWithOptions #Resolved
Contributor
Author
|
Thanks! |
zeahmed
added a commit
to zeahmed/machinelearning
that referenced
this pull request
Apr 8, 2019
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2522. The *.cs files are auto-generated. Please review the .tt and .ttinclude files.