Extend Gam Samples - #3281
Merged
Merged
Conversation
rogancarr
requested review from
Ivanidzo4ka,
artidoro,
codemzs,
sfilipi and
shmoradims
April 10, 2019 22:55
Codecov Report
@@ Coverage Diff @@
## master #3281 +/- ##
==========================================
+ Coverage 72.62% 72.64% +0.01%
==========================================
Files 807 807
Lines 145080 145191 +111
Branches 16213 16223 +10
==========================================
+ Hits 105368 105477 +109
- Misses 35294 35295 +1
- Partials 4418 4419 +1
|
wschin
reviewed
Apr 11, 2019
wschin
reviewed
Apr 11, 2019
wschin
reviewed
Apr 11, 2019
wschin
reviewed
Apr 11, 2019
…ification/Gam.cs Co-Authored-By: rogancarr <rogan.carr@hotmail.com>
…ification/Gam.cs Co-Authored-By: rogancarr <rogan.carr@hotmail.com>
wschin
reviewed
Apr 11, 2019
| @@ -0,0 +1,150 @@ | |||
| using System; | |||
Contributor
There was a problem hiding this comment.
Similar comments for Gam without Options apply here (and other sample files) #Resolved
…ification/Gam.cs Co-Authored-By: rogancarr <rogan.carr@hotmail.com>
…ification/Gam.cs Co-Authored-By: rogancarr <rogan.carr@hotmail.com>
wschin
approved these changes
Apr 11, 2019
wschin
left a comment
wschin
left a comment
Contributor
There was a problem hiding this comment.
Just leave some clarification comments. Overall LGTM.
shmoradims
reviewed
Apr 12, 2019
| else if (x < 0.25) | ||
| return 1; | ||
| else | ||
| return 0; |
There was a problem hiding this comment.
0 [](start = 23, length = 1)
is this the same as x < 0 value? #Resolved
Contributor
Author
There was a problem hiding this comment.
shmoradims
reviewed
Apr 12, 2019
| { | ||
| // Generate random, uncoupled features. | ||
| var data = new Data { | ||
| Features = new float[2] { (float)(rng.NextDouble() - 0.5), (float)(rng.NextDouble() - 0.5) } |
There was a problem hiding this comment.
(float)(rng.NextDouble() - 0.5) [](start = 46, length = 31)
i would define this as a lambda below rng definition to make the code cleaner.
var rndFloat => (float)(rng.NextDouble() - 0.5) #Resolved
shmoradims
reviewed
Apr 12, 2019
| // at least the default number of bins, as a small number of bins limits the capacity of | ||
| // the model. | ||
| var trainer = mlContext.BinaryClassification.Trainers.Gam( | ||
| new GamBinaryTrainer.Options { MaximumBinCountPerFeature = 16 }); |
There was a problem hiding this comment.
ptions { MaximumBinCountPerFeature = 16 } [](start = 38, length = 41)
can we use some options that are only available through Options class? #Resolved
rogancarr
added a commit
to rogancarr/machinelearning
that referenced
this pull request
Apr 12, 2019
* Adding Regression and Binary Classification GAM samples. (cherry picked from commit e37e5b1)
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the current GAM samples for regression and adds them for Binary Classification.
Fixes #3280