Skip to content

Upgrade matrix factorization samples - #3362

Merged
wschin merged 2 commits into
dotnet:masterfrom
wschin:tt-mf
Apr 17, 2019
Merged

Upgrade matrix factorization samples#3362
wschin merged 2 commits into
dotnet:masterfrom
wschin:tt-mf

Conversation

@wschin

@wschin wschin commented Apr 16, 2019

Copy link
Copy Markdown
Contributor

One more step toward #2522.

@wschin wschin added the documentation Related to documentation of ML.NET label Apr 16, 2019
@wschin wschin self-assigned this Apr 16, 2019
@codecov

codecov Bot commented Apr 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #3362 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3362      +/-   ##
==========================================
+ Coverage   72.69%   72.69%   +<.01%     
==========================================
  Files         807      807              
  Lines      145172   145172              
  Branches    16225    16225              
==========================================
+ Hits       105537   105539       +2     
+ Misses      35220    35219       -1     
+ Partials     4415     4414       -1
Flag Coverage Δ
#Debug 72.69% <ø> (ø) ⬆️
#production 68.23% <ø> (ø) ⬆️
#test 88.97% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.26% <0%> (+0.15%) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.9% <0%> (+0.2%) ⬆️

@shmoradims shmoradims left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

// This example requires installation of additional nuget package <a href="https://www.nuget.org/packages/Microsoft.ML.Recommender/">Microsoft.ML.Recommender</a>.
// In this example we will create in-memory data and then use it to train
// a matrix factorization model with default parameters. Afterward, quality metrics are reported.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this comment informative?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.

@yaeldekel yaeldekel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wschin
wschin merged commit 737af03 into dotnet:master Apr 17, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Related to documentation of ML.NET

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants