Skip to content

XML documentation for LightGBM Ranking trainer. - #3431

Merged
codemzs merged 3 commits into
dotnet:masterfrom
codemzs:lightgbmrankingdoc
Apr 20, 2019
Merged

XML documentation for LightGBM Ranking trainer.#3431
codemzs merged 3 commits into
dotnet:masterfrom
codemzs:lightgbmrankingdoc

Conversation

@codemzs

@codemzs codemzs commented Apr 19, 2019

Copy link
Copy Markdown
Member

towards #2522

@codecov

codecov Bot commented Apr 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #3431 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3431      +/-   ##
==========================================
- Coverage   72.73%   72.72%   -0.01%     
==========================================
  Files         807      807              
  Lines      145206   145206              
  Branches    16230    16230              
==========================================
- Hits       105614   105607       -7     
- Misses      35175    35181       +6     
- Partials     4417     4418       +1
Flag Coverage Δ
#Debug 72.72% <100%> (-0.01%) ⬇️
#production 68.27% <100%> (-0.01%) ⬇️
#test 88.98% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.FastTree/FastTreeRegression.cs 54.5% <ø> (ø) ⬆️
src/Microsoft.ML.LightGbm/LightGbmCatalog.cs 100% <ø> (ø) ⬆️
...rc/Microsoft.ML.FastTree/FastTreeClassification.cs 78.19% <ø> (ø) ⬆️
...rc/Microsoft.ML.FastTree/RandomForestRegression.cs 59.9% <ø> (ø) ⬆️
...icrosoft.ML.FastTree/RandomForestClassification.cs 78.07% <ø> (ø) ⬆️
...rc/Microsoft.ML.LightGbm/LightGbmRankingTrainer.cs 79.03% <100%> (ø) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0%> (-20.52%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.41%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 26.21% <0%> (+1.45%) ⬆️

@codemzs
codemzs force-pushed the lightgbmrankingdoc branch from ef2e837 to 4dcfd80 Compare April 19, 2019 23:20

@shmoradims shmoradims left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread src/Microsoft.ML.LightGbm/LightGbmRankingTrainer.cs
Comment thread src/Microsoft.ML.LightGbm/LightGbmRankingTrainer.cs
Comment thread src/Microsoft.ML.LightGbm/LightGbmCatalog.cs Outdated
Comment thread src/Microsoft.ML.LightGbm/LightGbmCatalog.cs Outdated
Comment thread src/Microsoft.ML.LightGbm/LightGbmRankingTrainer.cs
@codemzs
codemzs requested a review from natke April 19, 2019 23:37

@singlis singlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs
codemzs merged commit 35bc449 into dotnet:master Apr 20, 2019
@codemzs codemzs added the documentation Related to documentation of ML.NET label Apr 22, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Related to documentation of ML.NET

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants