Brew install libomp 7.0.0 only. - #3721
Conversation
There was a problem hiding this comment.
As mentioned in person, I think we should make sure we are working on fixing this temporary solution.
However, since any new PR is blocked right now I think this fix is fine for now.
If I understand correctly @najeeb-kazmi is going to work on fixing the build with libomp 8.0.0.
Codecov Report
@@ Coverage Diff @@
## master #3721 +/- ##
==========================================
+ Coverage 72.77% 72.78% +<.01%
==========================================
Files 808 808
Lines 145588 145588
Branches 16250 16250
==========================================
+ Hits 105956 105961 +5
+ Misses 35207 35203 -4
+ Partials 4425 4424 -1
|
eerhardt
left a comment
There was a problem hiding this comment.
Looks good to get the repo unblocked.
One question I had was: is this the best/right way to install a specific version? I'm no home brew expert.
|
@eerhardt I’m no home brew expert either but based on my research this afternoon it seems this is apparently the right way to install an earlier version of libomp. Thanks for approving. |
#3676) * Fix SoftMax precision by utilizing double in the internal calculations * Brew install libomp 7.0.0 only. (#3721) * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Fix SoftMax precision by utilizing double in the internal calculations
* Fix documentation for LightGbm parameter * Brew install libomp 7.0.0 only. (#3721) * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Fix documentation for LightGbm parameter
Stop gap fix until #3722 is fixed.