Skip to content

These changes allow for ML.NET to be built from source by VS2019 - #3742

Merged
PranovD merged 4 commits into
dotnet:masterfrom
PranovD:master
May 17, 2019
Merged

These changes allow for ML.NET to be built from source by VS2019 #3742
PranovD merged 4 commits into
dotnet:masterfrom
PranovD:master

Conversation

@PranovD

@PranovD PranovD commented May 16, 2019

Copy link
Copy Markdown
Contributor

Fixes #3739

@dnfclas

dnfclas commented May 16, 2019

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met. #Closed

@codemzs
codemzs self-requested a review May 17, 2019 01:07
Comment thread docs/building/windows-instructions.md Outdated
Comment thread src/Native/gen-buildsys-win.bat Outdated
@codemzs

codemzs commented May 17, 2019

Copy link
Copy Markdown
Member

@PranovD Great first PR on day 4 of your internship! I have few minor comments but otherwise looks great.

Also adding @eerhardt and @safern , our build experts to also take a look! #Closed

@codemzs
codemzs requested review from eerhardt and safern May 17, 2019 07:25
@PranovD PranovD changed the title These changes allow for ML.NET to be built from source by VS2019 #3739 These changes allow for ML.NET to be built from source by VS2019 May 17, 2019
Comment thread src/Native/gen-buildsys-win.bat

@codemzs codemzs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Added sample for WithOnFitDelegate (dotnet#3738)
@PranovD
PranovD merged commit b0fdb44 into dotnet:master May 17, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to build ML.NET from source with Visual Studio 2019

4 participants