Skip to content

Access indices array for VBuffer in KeyToVector transformer only when resulting vector is sparse. - #3763

Merged
codemzs merged 5 commits into
dotnet:masterfrom
codemzs:key2valuebug
May 22, 2019
Merged

Access indices array for VBuffer in KeyToVector transformer only when resulting vector is sparse.#3763
codemzs merged 5 commits into
dotnet:masterfrom
codemzs:key2valuebug

Conversation

@codemzs

@codemzs codemzs commented May 22, 2019

Copy link
Copy Markdown
Member

fixes #3757
fixes #1751
fixes #2678

@codemzs
codemzs requested review from eerhardt and yaeldekel May 22, 2019 09:37
@codemzs codemzs changed the title Access indices array for VBuffer in KeyToValue transformer only when resulting vector is sparse. Access indices array for VBuffer in KeyToVector transformer only when resulting vector is sparse. May 22, 2019
Comment thread src/Microsoft.ML.Data/Transforms/KeyToVector.cs
@codemzs
codemzs requested a review from wschin May 22, 2019 20:28

@eerhardt eerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread test/Microsoft.ML.Tests/Transformers/CategoricalTests.cs Outdated

@yaeldekel yaeldekel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs
codemzs merged commit 51b10fc into dotnet:master May 22, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

3 participants